From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, mathieu.poirier@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
quic_eberman@quicinc.com, kvalo@kernel.org,
loic.poulain@linaro.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Cc: quic_srichara@quicinc.com, quic_sjaganat@quicinc.com,
quic_kathirav@quicinc.com, quic_anusha@quicinc.com,
quic_varada@quicinc.com
Subject: Re: [PATCH v4 09/11] remoteproc: qcom: Add Hexagon based multipd rproc driver
Date: Fri, 28 Jul 2023 10:27:16 +0200 [thread overview]
Message-ID: <117f6341-55d7-601b-203f-8a09dd4bb22f@linaro.org> (raw)
In-Reply-To: <20230728063412.1641856-10-quic_mmanikan@quicinc.com>
On 28/07/2023 08:34, Manikanta Mylavarapu wrote:
> +
> +static int q6_get_inbound_irq(struct qcom_q6v5 *q6,
> + struct platform_device *pdev,
> + const char *int_name,
> + int index, int *pirq,
> + irqreturn_t (*handler)(int irq, void *data))
> +{
> + int ret, irq;
> + char *interrupt, *tmp = (char *)int_name;
> + struct q6_wcss *wcss = q6->rproc->priv;
> +
> + irq = platform_get_irq(pdev, index);
> + if (irq < 0) {
> + if (irq != -EPROBE_DEFER)
Still not good... I think I am saying this the third time: drop this
eprobe defer dance. It is not needed. Just open the definition of
dev_err_probe().
> + return dev_err_probe(&pdev->dev, irq,
> + "failed to retrieve %s IRQ: %d\n",
> + int_name, irq);
> + }
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-28 8:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 6:34 [PATCH v4 00/11] Add multipd remoteproc support Manikanta Mylavarapu
2023-07-28 6:34 ` [PATCH v4 01/11] dt-bindings: remoteproc: qcom: Add support for multipd model Manikanta Mylavarapu
2023-07-28 6:34 ` [PATCH v4 02/11] clk: qcom: ipq5332: remove q6 bring up clocks Manikanta Mylavarapu
2023-07-28 6:34 ` [PATCH v4 03/11] clk: qcom: ipq9574: " Manikanta Mylavarapu
2023-07-28 6:34 ` [PATCH v4 04/11] dt-bindings: clock: qcom: gcc-ipq5332: remove q6 bring up clock macros Manikanta Mylavarapu
2023-07-28 8:24 ` Krzysztof Kozlowski
2023-07-28 6:34 ` [PATCH v4 05/11] dt-bindings: clock: qcom: gcc-ipq9574: " Manikanta Mylavarapu
2023-07-28 8:24 ` Krzysztof Kozlowski
2023-07-28 6:34 ` [PATCH v4 06/11] firmware: qcom_scm: ipq5332: add support to pass metadata size Manikanta Mylavarapu
2023-07-28 6:34 ` [PATCH v4 07/11] firmware: qcom_scm: ipq5332: add msa lock/unlock support Manikanta Mylavarapu
2023-07-29 0:30 ` Guru Das Srinagesh
2023-07-31 5:14 ` Manikanta Mylavarapu
2023-07-28 6:34 ` [PATCH v4 08/11] remoteproc: qcom: q6v5: Add multipd interrupts support Manikanta Mylavarapu
2023-07-28 6:34 ` [PATCH v4 09/11] remoteproc: qcom: Add Hexagon based multipd rproc driver Manikanta Mylavarapu
2023-07-28 8:27 ` Krzysztof Kozlowski [this message]
2023-07-31 5:04 ` Manikanta Mylavarapu
2023-07-30 6:05 ` kernel test robot
2023-07-28 6:34 ` [PATCH v4 10/11] arm64: dts: qcom: ipq5332: Add nodes to bringup multipd Manikanta Mylavarapu
2023-07-28 6:34 ` [PATCH v4 11/11] arm64: dts: qcom: ipq9574: Add nodes to bring up multipd Manikanta Mylavarapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=117f6341-55d7-601b-203f-8a09dd4bb22f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mathieu.poirier@linaro.org \
--cc=mturquette@baylibre.com \
--cc=quic_anusha@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_mmanikan@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).