Re: [PATCH v2 4/5] phy: mediatek: ufs: Add support for resets

Peter Wang (王信友)
2025-10-17T06:53:57Z

On Thu, 2025-10-16 at 14:06 +0200, Nicolas Frattaroli wrote
>
> The MediaTek UFS PHY supports PHY resets. Until now, they've been
> implemented in the UFS host driver. Since they were never documented
> in
> the UFS HCI node's DT bindings, and no mainline DT uses it, it's fine
> if
> it's moved to the correct location, which is the PHY driver.
>
> Implement the MPHY reset logic in this driver and expose it through
> the
> phy subsystem's reset op. The reset itself is optional, as judging by
> other mainline devices that use this hardware, it's not required for
> the
> device to function.
>
> If no reset is present, the reset op returns -EOPNOTSUPP, which means
> that the ufshci driver can detect it's present and not double sleep
> in
> its own reset function, where it will call the phy reset.
>
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> Reviewed-by: AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

Reviewed-by: Peter Wang <peter.wang@mediatek.com>