From: "Heiko Stübner" <heiko@sntech.de>
To: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org, devicetree@vger.kernel.org,
linux-integrity@vger.kernel.org, Lukas Wunner <lukas@wunner.de>
Cc: Yannic Moog <Y.Moog@phytec.de>,
Alexander Bauer <a.bauer@phytec.de>,
upstream@lists.phytec.de, Teresa Remmet <T.Remmet@phytec.de>,
Tim Harvey <tharvey@gateworks.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
kernel@pengutronix.de, Fabio Estevam <festevam@gmail.com>,
linux-imx@nxp.com, Adam Ford <aford173@gmail.com>,
Heiko Thiery <heiko.thiery@gmail.com>,
Enric Balletbo i Serra <eballetbo@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Chen-Yu Tsai <wenst@chromium.org>,
Nicolas Prado <nfraprado@collabora.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH] arm64: dts: Fix TPM schema violations
Date: Sat, 13 Jan 2024 20:13:35 +0100 [thread overview]
Message-ID: <11865970.MucGe3eQFb@diego> (raw)
In-Reply-To: <e6d7768e2a257e0bd5948bcf168909b6c670851b.1705168605.git.lukas@wunner.de>
Hi Lukas,
Am Samstag, 13. Januar 2024, 19:06:56 CET schrieb Lukas Wunner:
> Since commit 26c9d152ebf3 ("dt-bindings: tpm: Consolidate TCG TIS
> bindings"), several issues are reported by "make dtbs_check" for arm64
> devicetrees:
>
> The compatible property needs to contain the chip's name in addition to
> the generic "tcg,tpm_tis-spi" and the nodename needs to be "tpm@0"
> rather than "cr50@0":
>
> tpm@1: compatible: ['tcg,tpm_tis-spi'] is too short
> from schema $id: http://devicetree.org/schemas/tpm/tcg,tpm_tis-spi.yaml#
>
> cr50@0: $nodename:0: 'cr50@0' does not match '^tpm(@[0-9a-f]+)?$'
> from schema $id: http://devicetree.org/schemas/tpm/google,cr50.yaml#
>
> Fix these schema violations.
>
> phyGATE-Tauri uses an Infineon SLB9670:
> https://lore.kernel.org/all/ab45c82485fa272f74adf560cbb58ee60cc42689.camel@phytec.de/
>
> Gateworks Venice uses an Atmel ATTPM20P:
> https://trac.gateworks.com/wiki/tpm
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> ---
> The commit mentioned above, 26c9d152ebf3 ("dt-bindings: tpm: Consolidate
> TCG TIS bindings") landed in Linus' tree yesterday.
>
> Because this consists only of fixes, I think it could be picked up and
> forwarded to Linus at any time, even outside the merge window.
>
> The issues reported for imx8m*-venice-gw7*xx.dts* devicetrees will not
> go away until Jarrko picks up this amendment patch for the dt-bindings:
> https://lore.kernel.org/all/8886271d52025065eddf5915bb7778ab14362255.1705140898.git.lukas@wunner.de/
>
> arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l.dts | 2 +-
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts | 2 +-
> arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 2 +-
> arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 2 +-
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 2 +-
> arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi | 2 +-
> arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts | 2 +-
> arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi | 2 +-
you might want to split this per sub-architecture perhaps (freescale,
mediatek, rockchip) as such dts changes normally go through the trees
of the subarchitecture maintainers.
For the rockchip-parts itself, I'm also fine with them going through
somewhere else - gru devices are pretty much "finished" by now,
so for the rockchip changes
Acked-by: Heiko Stuebner <heiko@sntech.de>
Heiko
next prev parent reply other threads:[~2024-01-13 19:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 18:06 [PATCH] arm64: dts: Fix TPM schema violations Lukas Wunner
2024-01-13 19:13 ` Heiko Stübner [this message]
2024-01-14 10:33 ` Lukas Wunner
2024-01-15 8:41 ` AngeloGioacchino Del Regno
2024-01-15 20:17 ` Arnd Bergmann
2024-01-16 10:24 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11865970.MucGe3eQFb@diego \
--to=heiko@sntech.de \
--cc=T.Remmet@phytec.de \
--cc=Y.Moog@phytec.de \
--cc=a.bauer@phytec.de \
--cc=aford173@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetbo@kernel.org \
--cc=festevam@gmail.com \
--cc=heiko.thiery@gmail.com \
--cc=hsinyi@chromium.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-imx@nxp.com \
--cc=linux-integrity@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
--cc=tharvey@gateworks.com \
--cc=upstream@lists.phytec.de \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).