From: Arnd Bergmann <arnd@arndb.de>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: 'Naveen Krishna Chatradhi' <ch.naveen@samsung.com>,
linux-arm-kernel@lists.infradead.org, naveenkrishna.ch@gmail.com,
linux-samsung-soc@vger.kernel.org, catalin.marinas@arm.com,
robh@kernel.org, devicetree@vger.kernel.org, t.figa@samsung.com
Subject: Re: [PATCH v2 5/7] arm64: dts: Add initial device tree support for EXYNOS7
Date: Wed, 03 Sep 2014 20:28:42 +0200 [thread overview]
Message-ID: <118816680.lTOkj0TsFJ@wuerfel> (raw)
In-Reply-To: <043401cfc794$7f228650$7d6792f0$@samsung.com>
On Thursday 04 September 2014 01:31:21 Kukjin Kim wrote:
> > This is the board specific file, so it seems ok.
> >
> I mean there are many espresso boards are having different exynos7
> SoC. I mean exynos7-espresso cannot represent all of espresso boards.
>
Ah, I see, that makes sense.
We definitely need a top-level .dts file for each board that is different
in a nondiscoverable way then.
If the mmc settings and possibly some other nodes (to be added later)
are common across them, those can be in a board specific .dtsi file.
For the memory node, I would actually expect that to be filled by
the boot loader, so we could leave it out entirely. The same applies
to the command line: the parts that are in there at the moment (
"console=ttySAC2,115200n8 root=/dev/ram0 ramdisk=16384 initrd=0x42000000,16M")
clearly don't belong into a generic dts file and none of them should be
set that way.
For the initial version, that would mean that the file comes down to having
as its only contents
/dts-v1/;
#include <dt-bindings/gpio/gpio.h>
#include "exynos7123.dtsi"
#include "exynos7-espresso.dtsi" // for the mmc nodes
/ {
model = "Samsung ESPRESSO board based on EXYNOS7123";
compatible = "samsung,espresso", "samsung,exynos7123", "samsung,exynos7";
};
One more thing I just noticed is the GPL statement in the dts files.
Can we please change that to a permissive license in order to allow
including it in non-GPL boot loaders and operating systems?
Dual GPL+MIT or GPL+BSD would make most sense here.
Arnd
next prev parent reply other threads:[~2014-09-03 18:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 15:35 [PATCH v2 0/7] arch: arm64: enable support for Samsung Exynos7 SoC Naveen Krishna Chatradhi
2014-09-02 15:35 ` [PATCH v2 1/7] clk: samsung: add support for 145xx and 1460x PLLs Naveen Krishna Chatradhi
2014-09-02 15:35 ` [PATCH v2 2/7] clk: samsung: Factor out the common code to clk.c Naveen Krishna Chatradhi
2014-09-02 15:35 ` [PATCH v2 3/7] clk: samsung: Add fixed_factor_clocks field to struct exynos_cmu_info Naveen Krishna Chatradhi
2014-09-02 15:35 ` [PATCH v2 4/7] clk: samsung: add initial clock support for Exynos7 SoC Naveen Krishna Chatradhi
2014-09-02 15:35 ` [PATCH v2 5/7] arm64: dts: Add initial device tree support for EXYNOS7 Naveen Krishna Chatradhi
2014-09-03 16:15 ` Kukjin Kim
2014-09-03 16:22 ` Arnd Bergmann
2014-09-03 16:31 ` Kukjin Kim
2014-09-03 18:28 ` Arnd Bergmann [this message]
2014-09-09 3:06 ` kgene
2014-09-09 3:28 ` kgene
2014-09-11 8:42 ` Naveen Krishna Ch
2014-09-02 15:35 ` [PATCH v2 6/7] tty/serial: samsung: enable usage for 64-bit Exynos platforms Naveen Krishna Chatradhi
2014-09-02 15:35 ` [PATCH v2 7/7] arm64: exynos7: Enable ARMv8 based Exynos7 (SoC) support Naveen Krishna Chatradhi
2014-09-02 16:37 ` [PATCH v2 0/7] arch: arm64: enable support for Samsung Exynos7 SoC Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=118816680.lTOkj0TsFJ@wuerfel \
--to=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=ch.naveen@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=robh@kernel.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox