From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E6A9C5479D for ; Mon, 9 Jan 2023 12:14:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233913AbjAIMOY (ORCPT ); Mon, 9 Jan 2023 07:14:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234641AbjAIMN6 (ORCPT ); Mon, 9 Jan 2023 07:13:58 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66C4B1A806 for ; Mon, 9 Jan 2023 04:13:56 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id z8-20020a05600c220800b003d33b0bda11so7023953wml.0 for ; Mon, 09 Jan 2023 04:13:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0Apvhoqi+OOOMQ4HR148na/DFjKLgEz3QcDuyY6Juuo=; b=cXWt+TZUXIaL9XldVhJ2vQAL0UbkG3l6tWldpJQy6EwO/KXPFQTOJh1Q627alitksd 3I+SxiZkYaZB4GFyIxrqdw4qQA2016UwUmC7gJiDkZVmifRLZfUdqPDdVdgSxdr+B3V8 iseK937jZMBLIs4melo7vjit8D+2bnhklYItCPewIdj14ACF14BSCtIwp0z7PCDkpndO yCEnRh/r6maQzdiDGt8I5S8U6zq9lrg+0qJHYzuxV5O/93UABmOYrr8td6EV/XlfYRNS ySV61YC9coDEBUMGOeRW/7Ph47TcK2kauv1iNm9V7srJ+Cewn3eahZc41oK6E4l+pJI4 IoHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Apvhoqi+OOOMQ4HR148na/DFjKLgEz3QcDuyY6Juuo=; b=hY6pjaws2BEF+QRUJxnw7b0BTvZzrpKw4mEmyVQk3iJOxiXXjjoE4ELbqtiLF8iYbe 1BYMS2X2JNdKyV208f9tno3/V29+Ycby0WHSkJ1v30/UtAtkN9izijBkGVr8un3jthez +w3g5MVafNULMZE9gUsw77HCC4jfP2Kn7nieHowKB6LxeeedvFj0wx0OOYTV1nnj/ux5 Rl4MacFnRGCWgdmg9nbmUlzm5ARxttRPAdiFHjTp8fpxCpM99pv64aTQK6i1Dc5QJOk1 kCM8BIfE9r0IzOrkED/3d5xUnK6Wf/UcegM3RojnLtSv1p2P4rT7hrF8ZEHN8fSlJTEe TnEw== X-Gm-Message-State: AFqh2kof2whRCk9eAVavGkv3YCil6D0UmC2fTOAojbWr28QhrG0xZqIf /MlJoBA8vbU7rRZ8ctSdLEhhHQ== X-Google-Smtp-Source: AMrXdXsILHpk+nalIB34Dpa0HY57tdFpemqwhDbetBXThq02zr0jZIk4EOyQv8rCh0UzImryFrdc8Q== X-Received: by 2002:a05:600c:3550:b0:3d9:ed30:6a73 with SMTP id i16-20020a05600c355000b003d9ed306a73mr3300171wmq.9.1673266434967; Mon, 09 Jan 2023 04:13:54 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id t12-20020a05600c198c00b003d9de0c39fasm13687845wmq.36.2023.01.09.04.13.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 04:13:54 -0800 (PST) Message-ID: <118e34d1-617e-3d95-c31b-73b99109fc40@linaro.org> Date: Mon, 9 Jan 2023 13:13:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 1/3] dt-bindings: reserved-memory: rmtfs: Make qcom,vmid an array To: Konrad Dybcio , linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: marijn.suijten@somainline.org, Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230109093947.83394-1-konrad.dybcio@linaro.org> <2bc5d781-499b-fe39-2dc5-92bc9ba8396d@linaro.org> <97dafa30-8b76-8bf9-4411-be6d10e4c71a@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <97dafa30-8b76-8bf9-4411-be6d10e4c71a@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/01/2023 12:41, Konrad Dybcio wrote: > > > On 9.01.2023 10:51, Krzysztof Kozlowski wrote: >> On 09/01/2023 10:39, Konrad Dybcio wrote: >>> Some SoCs mandate that the RMTFS is also assigned to the NAV VM, while >>> others really don't want that. Since it has to be conditional, turn >>> qcom,vmid into an u32 array so that we can handle the NAV case, as >>> well as other similar ones if they pop up in the future. >>> >>> Signed-off-by: Konrad Dybcio >>> --- >>> v2 -> v3: >>> Rewrite to accomodate for changes, don't pick up tags >>> >>> .../devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml b/Documentation/devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml >>> index 2998f1c8f0db..cfc2fda30eba 100644 >>> --- a/Documentation/devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml >>> +++ b/Documentation/devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml >>> @@ -27,9 +27,9 @@ properties: >>> identifier of the client to use this region for buffers >>> >>> qcom,vmid: >>> - $ref: /schemas/types.yaml#/definitions/uint32 >>> + $ref: /schemas/types.yaml#/definitions/uint32-array >>> description: > >>> - vmid of the remote processor, to set up memory protection >>> + Array of vmids of the remote processors, to set up memory protection >> >> You need now min and maxItems. > Hm, I tested it with and without: > > minItems: 1 > maxItems: 2 > > on DTs with either one or two VMIDs defined and neither complains.. You can also make a property like: qcom,vmid: true which will accept anything but it won't be correct approach. Properties should have some reasonable constraints. Otherwise binding is not really specific and is describing the interface in a very relaxed way. Best regards, Krzysztof