From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D61D2D061F; Mon, 22 Dec 2025 12:41:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766407311; cv=none; b=OFMGcnntYY5ACylOILTx+9Xl5a5zI4yJXqmNE0J5ykg9CoGZ6JmcDqWTfMAtvS497/89QqHZW9P+Q5Up79HRabrsiZpU1JZnk/RlySE8e9obGWa8MKFNGgabtdXJQEBwDyxwtQhQycnoXEGnrb366LhWvLKIgxrUDy2nwDVb46E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766407311; c=relaxed/simple; bh=0jLWywMwvub9ANVFh+BovBjJEWgC/UVgIbx367Jkk14=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rVnWICY7SgtPwFtyK07OGALEfQobUnq/bzI/oGb1KylamUnSzwALhzX0iTEjBeniVvQozW9gEjMWBNhESVo5EbMCv7p4JowhXRcwu6Rzal4QNw0JhDJkwvorpVIlp6gq9SArlyteTf2JLxwQ1c92j63jopNMav6rb91zhgRqhd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=Xb9+ukEq; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="Xb9+ukEq" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=vIp/UwT1ukgYhBEE+L8xIDZ0mrAdvInVqlAbyQDVXto=; b=Xb9+ukEqRoYiOZV+Jj4NrtRYVi cBCR/H+pxxaNLfeXG8gNjtuAwmzFfHi4LpRuWOjVnnE82P48AWzBxEnCZbDjKzj+jx2DDrNSKGmWO RvSIBa5ut+fPbnPl5gKPLovH92Zba3MjmSs5YBs7UBxYu0JeeVS3trpvNE5Z30BtbVs4/omnd1ZX4 0jph7KSv16WfDQuYgMbX/vqPIHcYed6A3avRPtwQgAz7zNkZ/sEOvHdU+U2+oHQ27Go965Msj0S8U qOCyytjGdoQ93CFPql0HJrRNi/4OyvcZewXZR2GbfduOXT8BCtVIkr6+gVJUPaHeQCnFzi2fQiyfw BP505BBA==; Received: from [194.95.143.137] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vXfEO-0005U6-94; Mon, 22 Dec 2025 13:41:44 +0100 From: Heiko Stuebner To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexey Charkov Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: rockchip: enable UFS controller on FriendlyElec NanoPi M5 Date: Mon, 22 Dec 2025 13:41:43 +0100 Message-ID: <119070978.nniJfEyVGO@phil> In-Reply-To: References: <20251201-nanopi-m5-ufs-v2-1-ece9c0ee17c4@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi Alexey, Am Donnerstag, 18. Dezember 2025, 15:05:39 Mitteleurop=C3=A4ische Normalzei= t schrieb Alexey Charkov: > Hi Heiko, >=20 > On Mon, Dec 1, 2025 at 3:35=E2=80=AFPM Alexey Charkov = wrote: > > > > The NanoPi M5 board supports pluggable UFS modules using the UFSHC > > inside its Rockchip RK3576 SoC. > > > > Enable the respective devicetree node and add its supply regulators. > > > > Link: https://wiki.friendlyelec.com/wiki/images/9/97/NanoPi_M5_LP5_2411= _SCH.pdf > > Signed-off-by: Alexey Charkov > > --- > > Changes in v2: > > - Describe UFS supply regulators > > - Add link to schematic > > - Link to v1: https://lore.kernel.org/r/20251127-nanopi-m5-ufs-v1-1-0d2= 8d157712c@gmail.com > > --- > > arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts | 27 +++++++++++++++= ++++++++ > > 1 file changed, 27 insertions(+) >=20 > Would you mind pulling this one, or do you have any reservations? > There hasn't been any discussion, but it looks like a pretty simple > change, runtime tested and schema-tested. Your patch fell directly into the dead-zone between -rc7 and -rc1 ;-) > + vcc1v2_ufs_vccq: regulator-vcc1v2-ufs-vccq { > + compatible =3D "regulator-fixed"; > + regulator-min-microvolt =3D <1200000>; > + regulator-max-microvolt =3D <1200000>; > + regulator-name =3D "vcc1v2_ufs_vccq"; > + vin-supply =3D <&vcc5v0_sys_s5>; > + en-supply =3D <&vcc_3v3_s3>; > + }; > + > + vcc1v8_ufs_vccq2: regulator-vcc1v8-ufs-vccq2 { > + compatible =3D "regulator-fixed"; > + regulator-min-microvolt =3D <1800000>; > + regulator-max-microvolt =3D <1800000>; > + regulator-name =3D "vcc1v8_ufs_vccq2"; > + vin-supply =3D <&vcc_1v8_s3>; > + en-supply =3D <&vdda_1v2_s0>; > + }; But where does the "en-supply" come from? For the life of me, I can't find any reference to it in either the bindings in the kernel, nor the dt-schema. Can you please point me to the part of the documentation where that is described? Thanks Heiko