From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varshini Rajendran <varshini.rajendran@microchip.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
nicolas.ferre@microchip.com, claudiu.beznea@microchip.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3 03/50] dt-bindings: net: cdns,macb: add sam9x7 ethernet interface
Date: Fri, 28 Jul 2023 13:44:30 +0200 [thread overview]
Message-ID: <11947259-1e05-40dd-c20f-422bb649214a@linaro.org> (raw)
In-Reply-To: <20230728102328.265410-1-varshini.rajendran@microchip.com>
On 28/07/2023 12:23, Varshini Rajendran wrote:
> Add documentation for sam9x7 ethernet interface.
>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/net/cdns,macb.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index bf8894a0257e..c9840a284322 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -59,6 +59,12 @@ properties:
> - cdns,gem # Generic
> - cdns,macb # Generic
>
> + - items:
> + - enum:
> + - microchip,sam9x7-gem # Microchip SAM9X7 gigabit ethernet interface
> + - enum:
> + - microchip,sama7g5-gem # Microchip SAMA7G5 gigabit ethernet interface
That's entirely different patch than before. Not correct also - drop the
second enum, because it cannot be enum.
Please provide changelogs explaining what happened in the patch. Sending
such huge patchset with changelog only in cover letter with very vague
description of changes is not helping.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-07-28 11:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 10:23 [PATCH v3 03/50] dt-bindings: net: cdns,macb: add sam9x7 ethernet interface Varshini Rajendran
2023-07-28 11:44 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11947259-1e05-40dd-c20f-422bb649214a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=claudiu.beznea@microchip.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=varshini.rajendran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).