* [PATCH v3 03/50] dt-bindings: net: cdns,macb: add sam9x7 ethernet interface
@ 2023-07-28 10:23 Varshini Rajendran
2023-07-28 11:44 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Varshini Rajendran @ 2023-07-28 10:23 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
conor+dt, nicolas.ferre, claudiu.beznea, netdev, devicetree,
linux-kernel
Cc: varshini.rajendran, Rob Herring
Add documentation for sam9x7 ethernet interface.
Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/net/cdns,macb.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
index bf8894a0257e..c9840a284322 100644
--- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
+++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
@@ -59,6 +59,12 @@ properties:
- cdns,gem # Generic
- cdns,macb # Generic
+ - items:
+ - enum:
+ - microchip,sam9x7-gem # Microchip SAM9X7 gigabit ethernet interface
+ - enum:
+ - microchip,sama7g5-gem # Microchip SAMA7G5 gigabit ethernet interface
+
reg:
minItems: 1
items:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v3 03/50] dt-bindings: net: cdns,macb: add sam9x7 ethernet interface
2023-07-28 10:23 [PATCH v3 03/50] dt-bindings: net: cdns,macb: add sam9x7 ethernet interface Varshini Rajendran
@ 2023-07-28 11:44 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-28 11:44 UTC (permalink / raw)
To: Varshini Rajendran, davem, edumazet, kuba, pabeni, robh+dt,
krzysztof.kozlowski+dt, conor+dt, nicolas.ferre, claudiu.beznea,
netdev, devicetree, linux-kernel
Cc: Rob Herring
On 28/07/2023 12:23, Varshini Rajendran wrote:
> Add documentation for sam9x7 ethernet interface.
>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/net/cdns,macb.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index bf8894a0257e..c9840a284322 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -59,6 +59,12 @@ properties:
> - cdns,gem # Generic
> - cdns,macb # Generic
>
> + - items:
> + - enum:
> + - microchip,sam9x7-gem # Microchip SAM9X7 gigabit ethernet interface
> + - enum:
> + - microchip,sama7g5-gem # Microchip SAMA7G5 gigabit ethernet interface
That's entirely different patch than before. Not correct also - drop the
second enum, because it cannot be enum.
Please provide changelogs explaining what happened in the patch. Sending
such huge patchset with changelog only in cover letter with very vague
description of changes is not helping.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-28 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-28 10:23 [PATCH v3 03/50] dt-bindings: net: cdns,macb: add sam9x7 ethernet interface Varshini Rajendran
2023-07-28 11:44 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).