From: Florian Fainelli <f.fainelli@gmail.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: netdev@vger.kernel.org, andrew@lunn.ch,
adam.rudzinski@arf.net.pl, hkallweit1@gmail.com,
richard.leitner@skidata.com, zhengdejin5@gmail.com,
devicetree@vger.kernel.org, kernel@pengutronix.de,
kuba@kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH net-next 3/3] net: phy: bcm7xxx: request and manage GPHY clock
Date: Fri, 4 Sep 2020 08:38:20 -0700 [thread overview]
Message-ID: <11e7a470-fabb-d679-e254-2a7acc354fc6@gmail.com> (raw)
In-Reply-To: <20200904061821.h67rmeare4n6l4d3@pengutronix.de>
On 9/3/2020 11:18 PM, Marco Felsch wrote:
> On 20-09-02 21:39, Florian Fainelli wrote:
>> The internal Gigabit PHY on Broadcom STB chips has a digital clock which
>> drives its MDIO interface among other things, the driver now requests
>> and manage that clock during .probe() and .remove() accordingly.
>
> Hi Florian,
>
> Seems like you added the same support here like I did for the smsc
> driver. So should I go with my proposed patch which can be adapted later
> after you guys figured out who to enable the required resources?
That seems fine to me, on your platform there appears to be an
assumption that we will be able to probe the SMSC PHY because everything
we need is already enabled, right? If so, this patch series does not
change that state.
--
Florian
next prev parent reply other threads:[~2020-09-04 15:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 4:39 [PATCH net-next 0/3] net: phy: Support enabling clocks prior to bus probe Florian Fainelli
2020-09-03 4:39 ` [PATCH net-next 1/3] " Florian Fainelli
2020-09-03 20:39 ` Andrew Lunn
2020-09-03 21:25 ` Andrew Lunn
2020-09-03 21:28 ` Rob Herring
2020-09-03 21:42 ` Andrew Lunn
2020-09-03 21:50 ` Florian Fainelli
2020-09-03 21:43 ` Florian Fainelli
2020-09-03 4:39 ` [PATCH net-next 2/3] net: phy: mdio-bcm-unimac: Enable GPHY resources during bus reset Florian Fainelli
2020-09-03 4:39 ` [PATCH net-next 3/3] net: phy: bcm7xxx: request and manage GPHY clock Florian Fainelli
2020-09-04 6:15 ` Marco Felsch
2020-09-04 15:37 ` Florian Fainelli
2020-09-07 7:34 ` Marco Felsch
2020-09-07 19:07 ` Marco Felsch
2020-09-04 6:18 ` Marco Felsch
2020-09-04 15:38 ` Florian Fainelli [this message]
2020-09-07 7:37 ` Marco Felsch
2020-09-04 4:04 ` [PATCH net-next 0/3] net: phy: Support enabling clocks prior to bus probe Florian Fainelli
2020-09-04 6:19 ` Adam Rudziński
2020-09-04 13:45 ` Andrew Lunn
2020-09-04 14:00 ` Adam Rudziński
2020-09-04 14:23 ` Andrew Lunn
2020-09-04 17:21 ` Adam Rudziński
2020-09-04 13:58 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11e7a470-fabb-d679-e254-2a7acc354fc6@gmail.com \
--to=f.fainelli@gmail.com \
--cc=adam.rudzinski@arf.net.pl \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=richard.leitner@skidata.com \
--cc=robh+dt@kernel.org \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).