From: Jyri Sarha <jsarha@ti.com>
To: dri-devel@lists.freedesktop.org, airlied@linux.ie,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
bcousson@baylibre.com, tony@atomide.com
Cc: rmk+kernel@arm.linux.org.uk, tomi.valkeinen@ti.com,
Jyri Sarha <jsarha@ti.com>
Subject: [PATCH v6 1/7] drm/tilcdc: Fix module unloading
Date: Wed, 27 May 2015 12:22:55 +0300 [thread overview]
Message-ID: <11f5aeadc96d41a8d40d096d044cc57884ca499c.1432718049.git.jsarha@ti.com> (raw)
In-Reply-To: <cover.1432718049.git.jsarha@ti.com>
Force crtc dpms off before destroying the crtc instead of just
checking the dpms state. This fixes warning message and frozen picture
after tilcdc module unloading.
Signed-off-by: Jyri Sarha <jsarha@ti.com>
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
index c735884..c2d5980 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
@@ -135,11 +135,12 @@ static void stop(struct drm_crtc *crtc)
tilcdc_clear(dev, LCDC_RASTER_CTRL_REG, LCDC_RASTER_ENABLE);
}
+static void tilcdc_crtc_dpms(struct drm_crtc *crtc, int mode);
static void tilcdc_crtc_destroy(struct drm_crtc *crtc)
{
struct tilcdc_crtc *tilcdc_crtc = to_tilcdc_crtc(crtc);
- WARN_ON(tilcdc_crtc->dpms == DRM_MODE_DPMS_ON);
+ tilcdc_crtc_dpms(crtc, DRM_MODE_DPMS_OFF);
drm_crtc_cleanup(crtc);
drm_flip_work_cleanup(&tilcdc_crtc->unref_work);
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-05-27 9:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 9:22 [PATCH v6 0/7] Use DRM component API in tilcdc to connect to tda998x Jyri Sarha
2015-05-27 9:22 ` Jyri Sarha [this message]
2015-05-27 9:22 ` [PATCH v6 2/7] drm/tilcdc: Remove tilcdc slave support for tda998x driver Jyri Sarha
2015-05-27 9:22 ` [PATCH v6 3/7] drm/tilcdc: Add support for external tda998x encoder Jyri Sarha
2015-05-27 9:22 ` [PATCH v6 4/7] drm/tilcdc: use pm_runtime_irq_safe() Jyri Sarha
[not found] ` <cover.1432718049.git.jsarha-l0cyMroinI0@public.gmane.org>
2015-05-27 9:22 ` [PATCH v6 5/7] drm/tilcdc: Add DRM_TILCDC_SLAVE_COMPAT for ti,tilcdc,slave binding support Jyri Sarha
2015-05-27 9:23 ` [PATCH v6 6/7] drm/tilcdc: Force building of DRM_TILCDC_SLAVE_COMPAT Jyri Sarha
2015-05-27 9:23 ` [PATCH v6 7/7] ARM: dts: am335x-boneblack: Use new binding for HDMI Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11f5aeadc96d41a8d40d096d044cc57884ca499c.1432718049.git.jsarha@ti.com \
--to=jsarha@ti.com \
--cc=airlied@linux.ie \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-omap@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).