From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Loeliger Subject: Re: [2/5] dtc: Use flex's YY_USER_ACTION feature to avoid code duplication Date: Thu, 02 Oct 2008 11:25:27 -0500 Message-ID: <1222964727.9242.10.camel@ld0161-tx32> References: <20081002140427.GD11662@yookeroo.seuss> <20081002140512.GE11662@yookeroo.seuss> <20081002140556.GF11662@yookeroo.seuss> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20081002140556.GF11662-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org To: David Gibson Cc: devicetree-discuss List-Id: devicetree@vger.kernel.org On Fri, 2008-10-03 at 00:05 +1000, David Gibson wrote: > Current, every lexer rule starts with some boiler plate to update the > yylloc value for use by the parser. One of the rules, even mistakenly > has a redundant allocation to one of the members. > > This patch uses the flex YY_USER_ACTION macro hook, which is executed > before every rule to avoid this duplication. > > Signed-off-by: David Gibson > > --- This, and the xstrdup() change are both excellent suggestions. jdl