From: Timur Tabi <timur@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>,
"Wang, Dongsheng" <dongsheng.wang@hxt-semitech.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"Zheng, Joey" <yu.zheng@hxt-semitech.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] dt-bindings: net: qcom: Add binding for shared mdio bus
Date: Wed, 19 Sep 2018 09:05:36 -0500 [thread overview]
Message-ID: <1226d3d3-e2ba-571d-5b70-b246cbde2fb6@kernel.org> (raw)
In-Reply-To: <20180919122521.GA26940@lunn.ch>
On 9/19/18 7:25 AM, Andrew Lunn wrote:
> ACPI is completely separate and should not affect the DT binding.
> I've not yet looked at the ACPI changes you added.
Just FYI, there is no device tree platform on which the upstream EMAC
driver works. All of the DT code in the driver is theoretical. It
worked once on a prototype platform, when I originally wrote the code,
but since then DT support is mostly a guess.
The focus of any patches for the EMAC should be ACPI, not DT. If
anything, ACPI support should come first. No one should be writing or
reviewing DT code before ACPI code.
The upstream EMAC driver is only known to work on the QDF2400, which is
an ACPI-only chip. I feel like I've been repeating this too often.
next prev parent reply other threads:[~2018-09-19 14:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 8:53 [PATCH v2 0/4] net: qcom/emac: add shared mdio bus support Wang Dongsheng
2018-09-17 8:53 ` [PATCH v2 2/4] dt-bindings: net: qcom: Add binding for shared mdio bus Wang Dongsheng
2018-09-17 14:50 ` Andrew Lunn
2018-09-17 16:47 ` Wang, Dongsheng
2018-09-17 16:54 ` Florian Fainelli
2018-09-18 8:47 ` Wang, Dongsheng
2018-09-18 12:35 ` Andrew Lunn
2018-09-19 9:19 ` Wang, Dongsheng
2018-09-19 12:25 ` Andrew Lunn
2018-09-19 14:05 ` Timur Tabi [this message]
2018-09-19 15:20 ` Andrew Lunn
2018-09-20 13:42 ` Timur Tabi
2018-09-20 1:33 ` Wang, Dongsheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226d3d3-e2ba-571d-5b70-b246cbde2fb6@kernel.org \
--to=timur@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.wang@hxt-semitech.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yu.zheng@hxt-semitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).