From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Gupta, Nipun" <Nipun.Gupta@amd.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"song.bao.hua@hisilicon.com" <song.bao.hua@hisilicon.com>,
"mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>,
"maz@kernel.org" <maz@kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"jeffrey.l.hugo@gmail.com" <jeffrey.l.hugo@gmail.com>,
"saravanak@google.com" <saravanak@google.com>,
"Michael.Srba@seznam.cz" <Michael.Srba@seznam.cz>,
"mani@kernel.org" <mani@kernel.org>,
"yishaih@nvidia.com" <yishaih@nvidia.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>, "jgg@nvidia.com" <jgg@nvidia.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"will@kernel.org" <will@kernel.org>,
"joro@8bytes.org" <joro@8bytes.org>,
"masahiroy@kernel.org" <masahiroy@kernel.org>,
"ndesaulniers@google.com" <ndesaulniers@google.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "okaya@kernel.org" <okaya@kernel.org>,
"Anand, Harpreet" <harpreet.anand@amd.com>,
"Agarwal, Nikhil" <nikhil.agarwal@amd.com>,
"Simek, Michal" <michal.simek@amd.com>,
"git (AMD-Xilinx)" <git@amd.com>
Subject: Re: [PATCH 03/19] dt-bindings: bus: add CDX bus controller device tree bindings
Date: Wed, 18 Jan 2023 13:43:27 +0100 [thread overview]
Message-ID: <12358dd7-d600-0b2c-96ab-518ee2e65404@linaro.org> (raw)
In-Reply-To: <DM6PR12MB3082BE8616F773B990146866E8C79@DM6PR12MB3082.namprd12.prod.outlook.com>
On 18/01/2023 13:39, Gupta, Nipun wrote:
> [AMD Official Use Only - General]
Fix your email client. This is not helping us. What shall I do with it?
>
>
>
(...)
>>> +properties:
>>> + compatible:
>>> + const: xlnx,cdxbus-controller
>>
>> This misses SoC specific compatible. Drop "bus" - redundant. I would
>> also say - drop controller - do you see any other devices with such
>> compatible naming? Use naming consistent with other devices in the
>> kernel. Just open some controllers - SPI, I2C etc. and look there.
>
> Makes sense. Will use "xlnx,cdx" in compatible.
No, this still misses device specific compatible. You did ignored half
of my comment now.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-18 13:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 13:41 [PATCH 0/7] add support for CDX bus Nipun Gupta
2023-01-17 13:41 ` [PATCH 01/19] bus/cdx: add the cdx bus driver Nipun Gupta
2023-01-17 14:07 ` Greg KH
2023-01-18 10:56 ` Gupta, Nipun
2023-01-17 17:21 ` Randy Dunlap
2023-01-18 10:59 ` Gupta, Nipun
2023-01-17 13:41 ` [PATCH 02/19] iommu/arm-smmu-v3: support ops registration for CDX bus Nipun Gupta
2023-01-17 13:41 ` [PATCH 03/19] dt-bindings: bus: add CDX bus controller device tree bindings Nipun Gupta
2023-01-17 17:54 ` Krzysztof Kozlowski
2023-01-18 12:39 ` Gupta, Nipun
2023-01-18 12:43 ` Krzysztof Kozlowski [this message]
2023-01-19 7:33 ` Gupta, Nipun
2023-01-17 13:41 ` [PATCH 04/19] bus/cdx: add MCDI protocol interface for firmware interaction Nipun Gupta
2023-01-17 14:08 ` Greg KH
2023-01-18 10:58 ` Gupta, Nipun
2023-01-17 13:41 ` [PATCH 05/19] bus/cdx: add cdx controller Nipun Gupta
2023-01-17 14:10 ` Greg KH
2023-01-18 12:36 ` Gupta, Nipun
2023-01-17 13:41 ` [PATCH 06/19] bus/cdx: add rpmsg communication channel for CDX Nipun Gupta
2023-01-17 13:41 ` [PATCH 07/19] bus/cdx: add device attributes Nipun Gupta
2023-01-17 14:13 ` Greg KH
2023-01-18 13:03 ` Gupta, Nipun
2023-01-17 17:47 ` [PATCH 0/7] add support for CDX bus Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12358dd7-d600-0b2c-96ab-518ee2e65404@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Michael.Srba@seznam.cz \
--cc=Nipun.Gupta@amd.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=eric.auger@redhat.com \
--cc=f.fainelli@gmail.com \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=harpreet.anand@amd.com \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=masahiroy@kernel.org \
--cc=maz@kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=michal.simek@amd.com \
--cc=ndesaulniers@google.com \
--cc=nikhil.agarwal@amd.com \
--cc=okaya@kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@google.com \
--cc=song.bao.hua@hisilicon.com \
--cc=will@kernel.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).