From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Date: Wed, 31 Aug 2016 19:40:21 +0200 Message-ID: <12377780.GCreFUiXAa@amdc1976> References: <1472645679-5696-1-git-send-email-javier@osg.samsung.com> <5366f8a4-b4fb-ec2d-eb1e-5534f24c4a07@kernel.org> <0da13ae1-90a8-912b-227e-0e94439953d5@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Return-path: In-reply-to: <0da13ae1-90a8-912b-227e-0e94439953d5-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Javier Martinez Canillas Cc: Krzysztof Kozlowski , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kukjin Kim , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Mark Rutland List-Id: devicetree@vger.kernel.org Hi, On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote: > > On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote: > >> Hello Krzysztof, > >> > >> This series removes the usage of the skeleton.dtsi in all the Exynos dts, > >> which allows to get rid of the DTC warnings about a mismatch between the > >> memory nodes' unit names and reg properties. > >> > >> Patches are pretty trivial and shouldn't cause functional changes AFAIK, > >> but only the Exynos5 changes have been tested. The others patches were > >> just built tested. > > > > I think this is a common problem, not only Exynos-specific, so I would > > That's correct. > > > prefer to stick to common pattern. Either all DTS/DTSI include skeleton > > or none of them. > > > > The idea is to get rid of skeleton.dtsi [0], but that will of course take > time until the dtsi is removed from all the files. So this patch is a step > in the right direction so at least Exynos is not a blocker to remove it. Krzysztof's point is valid. If you are going to convert all DTS/DTSI then it is okay to apply Exynos specific changes, otherwise the code should stay as it is currently. Exynos won't be a blocker since we have your patches now and they can be applied when/if needed ;).. > > Best regards, > > Krzysztof > > > > [0]: https://lkml.org/lkml/2016/8/3/195 > > Best regards, Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html