From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDF481E6DD7 for ; Wed, 4 Sep 2024 19:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725477367; cv=none; b=jSBkPqvpvy9GkR2/NhN1uOPYrtIC5ybLPt2f8DnT4pXnZe2loXISGDASpO6hdXYo55IGmXrcTR+cipUtZucXb5Y4ZwUQDCIxE8J+WhyN/EribXNDZMM2g0GBtL8Hx1KUDjxgKgqCCuBVkttT2u/8wZwtxaciqYtDLUu+E7zxlos= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725477367; c=relaxed/simple; bh=WfiusaYUI7NNzYn1hMW8VCzKpjGkVmzh//jhn7WhvkE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CXgU+zZ8sSVDwBVhdk6CLoD4OJ9AZxCr+M/8+B3DW3jIbw4dgRUMtFELWuXZJh9fu9jnPBpXiFGkdUe+1K0K5nocEN96LTbzdy0iC2gYEmBidSAgghcJeZYr1kkBq9fVL+l78qvXXXbtqH+LbbbdIDfxw6uE8B2qwYueK3pZpXE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=fXzKZowl; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="fXzKZowl" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7a8049d4a40so387853085a.1 for ; Wed, 04 Sep 2024 12:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1725477363; x=1726082163; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ryDbdQ2D/+rou29MCfRgv3SUSfdPjKb5CferA/8Ns4w=; b=fXzKZowlbkqs/NlOpWRcR6KrIniw1FRcC4AYbwahzwJ6dD3TFtWhHMLCvee1beh488 Xrc8mslFybfN/7CEcVEutnck+e1dPHarX/chM7zlhgdfr51AoliBUG+bbdOpv5ip7nX6 rK2JUhV57+iMK/HKMrDBdIAJKcg9YxEauPvQEy3KdIF6RU5LQ7Mii9LMXt7BXI1+pCYk 43z7V9jhVAyvh+JRzg6dx64Plurv9llVZkl+027CI3ugJ+RRG3/qpYhHdC27bcMYir5D hlhgb8y2IliMquK3oom+0LaOpu9H6GGwwSezhThLHUasMvCjS+mzfawxP8p/j2IbsEtI q0ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725477363; x=1726082163; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ryDbdQ2D/+rou29MCfRgv3SUSfdPjKb5CferA/8Ns4w=; b=Oo5stJspx3VzpiS9ORhkanKhB7YREOF1zjrlY2fUviLbiTmj0m5VoV0icH7aTOb8UO D85YWFirKjlt289+Cxzhi/E4jikbVj86m8feWtMNgN3AotIfadf8L+oNEJsgCkQlAYn/ ZaX0wuHoEWPUUuQqBjWiPpaM3qBMIFSW3ecI2FLzz9KsU9vaDKFtaqcGbf1XxvuhmSk8 HUd9ywv3TzRzjL4X0O3IvAL8bw34/CVpdsQHoAMG+NdpeKbw/s6zd//4X5CXkK4QyIiW j+l+ZKa2sHJv5CoEDsfgjcT/hzO2AisOMFtVnSx+X0hIGMW6nE5vTlQSwFz/rpmXbd+k Dt/A== X-Forwarded-Encrypted: i=1; AJvYcCXuvm5HM0rNJko7dzjZnmOmmK4bWDteRzemzt2IxUT9w4d38j9nsDB5E5dwlixrQeXXi2ojibTLFO7V@vger.kernel.org X-Gm-Message-State: AOJu0Yxl5M8/QFNth+xLnEDa24KYGiUfki/BRGxVVA1r6J66v00A17VE qB9HoFnPzximurh65EyoZ4Jnf7yKynPFlDS3/yXwY7bHdCGLFrv2iNqOq63aDOQ= X-Google-Smtp-Source: AGHT+IFiAMwM665JnKMTu/rsJXEnquw0Kjt7PP7GRDGavSs2IapuyxpuZ6LmY1UP4XZ7M7H6uU8GAA== X-Received: by 2002:a05:620a:2989:b0:7a2:32e:3c41 with SMTP id af79cd13be357-7a97bd2b1a5mr812257685a.60.1725477363333; Wed, 04 Sep 2024 12:16:03 -0700 (PDT) Received: from [192.168.40.12] (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a98ef4742fsm9940285a.58.2024.09.04.12.16.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 12:16:02 -0700 (PDT) Message-ID: <123c8bff-6623-4a3b-a49e-69b3ab6f8ab5@baylibre.com> Date: Wed, 4 Sep 2024 15:16:01 -0400 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/3] iio: adc: add new ad7625 driver To: Lars-Peter Clausen , Michael Hennerich , =?UTF-8?Q?Nuno_S=C3=A1?= , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , David Lechner , Uwe Kleine-Konig Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20240904-ad7625_r1-v4-0-78bc7dfb2b35@baylibre.com> Content-Language: en-US From: Trevor Gamblin In-Reply-To: <20240904-ad7625_r1-v4-0-78bc7dfb2b35@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-09-04 3:14 p.m., Trevor Gamblin wrote: > This series adds a new driver for the Analog Devices Inc. AD7625, > AD7626, AD7960, and AD7961. These chips are part of a family of > LVDS-based SAR ADCs. The initial driver implementation does not support > the devices' self-clocked mode, although that can be added later. > > The devices make use of two offset PWM signals, one to trigger > conversions and the other as a burst signal for transferring data to the > host. These rely on the new PWM waveform functionality being > reviewed in [1] and also available at [2]. > > This work is being done by BayLibre and on behalf of Analog Devices > Inc., hence the maintainers are @analog.com. > > Special thanks to David Lechner for his guidance and reviews. > > [1]: https://lore.kernel.org/linux-pwm/cover.1722261050.git.u.kleine-koenig@baylibre.com > [2]: https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git/log/?h=pwm/chardev > > Signed-off-by: Trevor Gamblin Realizing that I forgot to pick up Conor's Reviewed-by on the v3 binding before sending. Can that be picked up? > --- > Changes in v4: > - Link to v3: https://lore.kernel.org/r/20240819-ad7625_r1-v3-0-75d5217c76b5@baylibre.com > - Rebase on top of latest pwm/chardev branch at: > https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git/log/?h=pwm/chardev > > [PATCH 1/3] > - No change > > [PATCH 2/3] > - Add 'depends on PWM' under 'CONFIG AD7625' in > drivers/iio/adc/Kconfig, based on v3 discussions > - Cleanup whitespace usage in Kconfig, bandwidth logic to match > Jonathan's suggestions > > [PATCH 3/3] > - No change > > Changes in v3: > - Link to v2: https://lore.kernel.org/r/20240809-ad7625_r1-v2-0-f85e7ac83150@baylibre.com > > [PATCH 1/3] > - Add gpio bindings header, en0-gpios and en1-gpios to binding example > - Remove unnecessary comments > > [PATCH 2/3] > - No change > > [PATCH 3/3] > - No change > > Changes in v2: > - Link to v1 (marked as RFC): https://lore.kernel.org/r/20240731-ad7625_r1-v1-0-a1efef5a2ab9@baylibre.com > - Include link to required PWM patch series in cover letter (missing before) > - Include new link to the pwm/chardev branch of Uwe's kernel tree > > [PATCH 1/3] > - Rework dt bindings to be compliant using make dt_binding_check > - Add "adi,no-dco" flag to address indication of how DCO lines are > configured > - Fix binding patch message > - Remove chip packaging info from binding description > - Move comments around to be clearer > > [PATCH 2/3] > - Remove ad7625_pwm_disable(), call pwm_disable() directly > - Add ad7625_buffer_preenable() and ad7625_buffer_postdisable() > functions > - Add devm_ad7625_regulator_setup() function, move all regulator logic > to it, consolidate the comment blocks related to it above > - Add have_refin flag in ad7625_state struct > - Add pwm_waveform structs to ad7625_state struct for storing > requested waveform characteristics > - Refactor ad7625_set_sampling_freq() to set the pwm_waveform struct > values in ad7625_state, limiting PWM enable/disable to > preenable/postdisable functions > - Remove redundant dev_err_probe() after devm_ad7625_pwm_get() > - Use device_property_read_bool() instead of device_property_present() > - General alignment and line wrapping fixes > > [PATCH 3/3] > - No change > > --- > Trevor Gamblin (3): > dt-bindings: iio: adc: add AD762x/AD796x ADCs > iio: adc: ad7625: add driver > docs: iio: new docs for ad7625 driver > > .../devicetree/bindings/iio/adc/adi,ad7625.yaml | 176 ++++++ > Documentation/iio/ad7625.rst | 91 +++ > MAINTAINERS | 11 + > drivers/iio/adc/Kconfig | 16 + > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/ad7625.c | 684 +++++++++++++++++++++ > 6 files changed, 979 insertions(+) > --- > base-commit: 1ebd3850421749eb44bd040b249bd4db88d35b33 > change-id: 20240730-ad7625_r1-60d17ea28958 > > Best regards,