From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Feng Kan <fkan-qTEPVZfXA3Y@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
dbaryshkov <dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
dwmw2 <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
patches <patches-qTEPVZfXA3Y@public.gmane.org>
Subject: Re: [PATCH V7 1/6] power: reset: Add generic SYSCON register mapped reset
Date: Fri, 27 Jun 2014 09:23:32 +0200 [thread overview]
Message-ID: <12435553.7pqAlNHzh1@wuerfel> (raw)
In-Reply-To: <CAL85gmCOzaT+dJf9e8Uj-w3v1nq8Qjg-EXfWDN5kdrU2k=kHJQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thursday 26 June 2014 09:51:14 Feng Kan wrote:
> >> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> >> index bdcf517..7035236 100644
> >> --- a/drivers/power/reset/Kconfig
> >> +++ b/drivers/power/reset/Kconfig
> >> @@ -80,3 +80,9 @@ config POWER_RESET_KEYSTONE
> >> help
> >> Reboot support for the KEYSTONE SoCs.
> >>
> >> +config POWER_RESET_SYSCON
> >> + bool "Generic SYSCON regmap reset driver"
> >> + depends on ARCH_XGENE
> >
> > If this is supposed to be generic, why are you depending on
> > a certain platform?
>
> Yes, the problem was that it was breaking the x86 build.
You probably need to list the exact dependencies then, at least make
it depend on MFD_SYSCON and OF. We generally want all drivers to
build without warnings on all architectures. You can limit it to
(ARM || ARM64 || COMPILE_TEST) if you don't want it to show up on
x86 by default, but it should still be possible to build it when
COMPILE_TEST is set.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-06-27 7:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 23:03 [PATCH V7 0/6] Add X-Gene platform reboot mechanism Feng Kan
2014-06-25 23:03 ` [PATCH V7 1/6] power: reset: Add generic SYSCON register mapped reset Feng Kan
2014-06-26 1:38 ` Chen-Yu Tsai
[not found] ` <CAGb2v65mGXDGb8Y045kehKufpMZWnfBm4dBJarJeOa8j-3g0RQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-26 16:51 ` Feng Kan
[not found] ` <CAL85gmCOzaT+dJf9e8Uj-w3v1nq8Qjg-EXfWDN5kdrU2k=kHJQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-27 7:23 ` Arnd Bergmann [this message]
2014-06-25 23:03 ` [PATCH V7 2/6] Documentation: power: reset: Add documentation for generic SYSCON reboot driver Feng Kan
2014-06-25 23:03 ` [PATCH V7 3/6] Documentation: arm64: add SCU dts binding documentation to linux kernel Feng Kan
[not found] ` <1403737406-6474-1-git-send-email-fkan-qTEPVZfXA3Y@public.gmane.org>
2014-06-25 23:03 ` [PATCH V7 4/6] arm64: dts: Add X-Gene reboot driver dts node Feng Kan
2014-06-25 23:03 ` [PATCH V7 5/6] arm64: Select reboot driver for X-Gene platform Feng Kan
2014-06-25 23:03 ` [PATCH V7 6/6] power: reset: Remove X-Gene reboot driver Feng Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12435553.7pqAlNHzh1@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=fkan-qTEPVZfXA3Y@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=patches-qTEPVZfXA3Y@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox