devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luca Weiss <luca@z3ntu.xyz>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Andy Gross <agross@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc
Date: Mon, 20 May 2024 17:11:59 +0200	[thread overview]
Message-ID: <12437992.O9o76ZdvQC@g550jk> (raw)
In-Reply-To: <1ab150cd-68f0-4153-8d4e-5bd30bb01dfe@linaro.org>

On Montag, 20. Mai 2024 08:46:39 MESZ Krzysztof Kozlowski wrote:
> On 15/05/2024 17:06, Luca Weiss wrote:
> > Hi Rob,
> > 
> > Any feedback on the below topic?
> 
> Can be explained in description, like
> mboxes:
>   description: Each entry corresponds to one remote processor
>   maxItems: 5

Hi Krzysztof

Ack, sounds good.

Maybe also from you, any opinion between these two binding styles?

So first using index of mboxes for the numbering, where for the known
usages the first element (and sometimes the 3rd - ipc-2) are empty <>.

The second variant is using mbox-names to get the correct channel-mbox
mapping.

-               qcom,ipc-1 = <&apcs 8 13>;
-               qcom,ipc-2 = <&apcs 8 9>;
-               qcom,ipc-3 = <&apcs 8 19>;
+               mboxes = <0>, <&apcs 13>, <&apcs 9>, <&apcs 19>;

vs.

-               qcom,ipc-1 = <&apcs 8 13>;
-               qcom,ipc-2 = <&apcs 8 9>;
-               qcom,ipc-3 = <&apcs 8 19>;
+               mboxes = <&apcs 13>, <&apcs 9>, <&apcs 19>;
+               mbox-names = "ipc-1", "ipc-2", "ipc-3";

Regards
Luca

> 
> Best regards,
> Krzysztof
> 
> 





  reply	other threads:[~2024-05-20 15:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 17:21 [PATCH RFC 0/2] Support mailbox interface in qcom,smsm driver Luca Weiss
2024-04-24 17:21 ` [PATCH RFC 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc Luca Weiss
2024-04-25 16:17   ` Rob Herring
2024-04-25 18:54     ` Luca Weiss
2024-05-15 15:06       ` Luca Weiss
2024-05-20  6:46         ` Krzysztof Kozlowski
2024-05-20 15:11           ` Luca Weiss [this message]
2024-05-21  8:58             ` Krzysztof Kozlowski
2024-05-21 20:35               ` Luca Weiss
2024-05-22  6:49                 ` Krzysztof Kozlowski
2024-05-22 17:34                   ` Luca Weiss
2024-05-23  6:02                     ` Krzysztof Kozlowski
2024-05-23  6:16                       ` Luca Weiss
2024-05-23  6:19                         ` Krzysztof Kozlowski
2024-05-24 17:55                           ` Luca Weiss
2024-05-25 16:47                             ` Krzysztof Kozlowski
2024-05-29 15:28                               ` Luca Weiss
2024-04-24 17:21 ` [PATCH RFC 2/2] soc: qcom: smsm: Support using mailbox interface Luca Weiss
2024-04-24 20:13   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12437992.O9o76ZdvQC@g550jk \
    --to=luca@z3ntu.xyz \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).