From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.Li@nxp.com>, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names
Date: Thu, 29 Feb 2024 10:46:38 +0100 [thread overview]
Message-ID: <1251bf21-c65e-4749-ad14-78ddf5cae7ab@linaro.org> (raw)
In-Reply-To: <20240228-asrc_8qxp-v3-3-d4d5935fd3aa@nxp.com>
On 28/02/2024 20:14, Frank Li wrote:
> Some sai only connect one direction. So allow only "rx" or "tx" for
> dma-names.
"one direction" was already allowed. Explain really what is the
different, e.g. you expect only TX?
This applies to all your recent patches - they all have insufficient
explanation. Often they explain what you are doing, but not why.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-29 9:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 19:14 [PATCH v3 0/4] arm64: dts: imx8qxp add asrc and sai Frank Li
2024-02-28 19:14 ` [PATCH v3 1/4] ASoC: dt-bindings: fsl,imx-asrc/spdif: Add power-domains requirement Frank Li
2024-02-29 9:44 ` Krzysztof Kozlowski
2024-03-01 4:01 ` Frank Li
2024-03-01 6:30 ` Krzysztof Kozlowski
2024-03-01 15:42 ` Frank Li
2024-03-04 15:05 ` Krzysztof Kozlowski
2024-03-04 15:39 ` Frank Li
2024-02-28 19:14 ` [PATCH v3 2/4] ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers Frank Li
2024-02-29 9:44 ` Krzysztof Kozlowski
2024-03-01 4:03 ` Frank Li
2024-03-01 6:30 ` Krzysztof Kozlowski
2024-03-01 15:39 ` Frank Li
2024-03-04 14:56 ` Rob Herring
2024-02-28 19:14 ` [PATCH v3 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names Frank Li
2024-02-29 9:46 ` Krzysztof Kozlowski [this message]
2024-03-01 4:06 ` Frank Li
2024-03-04 14:58 ` Rob Herring
2024-02-28 19:14 ` [PATCH v3 4/4] arm64: dts: imx8qxp: add asrc[0,1], esai0, spdif[0,1] and sai[4,5] Frank Li
2024-03-01 4:53 ` [PATCH v3 0/4] arm64: dts: imx8qxp add asrc and sai Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251bf21-c65e-4749-ad14-78ddf5cae7ab@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Frank.Li@nxp.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).