From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: [RFC] scripts/get_maintainer: add emails based on keywords in the patch Date: Fri, 9 Oct 2009 12:32:59 +0200 Message-ID: <1255084379-12954-1-git-send-email-w.sang@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org To: linux-kernel@vger.kernel.org Cc: devicetree-discuss@ozlabs.org, linuxppc-dev@ozlabs.org, Joe Perches List-Id: devicetree@vger.kernel.org Make get_maintainer.pl scan the modifying lines of a patch for a list of keywords and add an associated email if found. The first user is the devicetree-discuss mailing list which should always be cc'ed if a device tree property is inserted/removed (keyword 'of_get_property'). This patch is the result from commit 1965d30356c1c65660ba3330927671cfe81acdd5 entering mainline which seems to have been missed by all parties interested in the device tree (and at least had the documentation missing). As adding properties can happen anywhere and so there is no fitting fileglob, this keyword based approach is proposed. Signed-off-by: Wolfram Sang Cc: Joe Perches Cc: Grant Likely Cc: Anton Vorontsov --- scripts/get_maintainer.pl | 24 ++++++++++++++++-------- 1 files changed, 16 insertions(+), 8 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index cdb44b6..e1150ea 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -44,6 +44,11 @@ my $help = 0; my $exit = 0; +my %keywords_to_mail = ( + 'of_get_property' => 'L: devicetree-discuss@lists.ozlabs.org', +); +my $keywords_to_mail_match = join('|', keys %keywords_to_mail); + my @penguin_chief = (); push(@penguin_chief,"Linus Torvalds:torvalds\@linux-foundation.org"); #Andrew wants in on most everything - 2009/01/14 @@ -188,6 +193,12 @@ if ($email_remove_duplicates) { my @files = (); my @range = (); +my @email_to = (); +my @list_to = (); +my @scm = (); +my @web = (); +my @subsystem = (); +my @status = (); foreach my $file (@ARGV) { ##if $file is a directory and it lacks a trailing slash, add one @@ -213,7 +224,11 @@ foreach my $file (@ARGV) { if ($email_git_blame) { push(@range, "$lastfile:$1:$2"); } - } + # Check the lines which a patch modifies for keywords; add mail if found. + } elsif (m/^[+-].*($keywords_to_mail_match)/o) { + (my $keyword_mail = $keywords_to_mail{$1}) =~ s/^([LM]): //; + push( @{ ($1 eq 'L') ? \@list_to : \@email_to }, $keyword_mail ); + } } close(PATCH); if ($file_cnt == @files) { @@ -224,13 +239,6 @@ foreach my $file (@ARGV) { } } -my @email_to = (); -my @list_to = (); -my @scm = (); -my @web = (); -my @subsystem = (); -my @status = (); - # Find responsible parties foreach my $file (@files) { -- 1.6.3.3