From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A363C433FE for ; Mon, 14 Nov 2022 15:53:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237252AbiKNPxl (ORCPT ); Mon, 14 Nov 2022 10:53:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237146AbiKNPxi (ORCPT ); Mon, 14 Nov 2022 10:53:38 -0500 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04CEA2D748 for ; Mon, 14 Nov 2022 07:53:37 -0800 (PST) Received: by mail-lj1-x22b.google.com with SMTP id s24so13737674ljs.11 for ; Mon, 14 Nov 2022 07:53:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=iFWd2m5XWAIUBukAvtG87ESkORevoEKwbahoShbsHGs=; b=gHKpaujIP4yqkPLWSxP/u7oOLFIAUkdMqLmA2+M/QEBY4DUULV8ZWQ2SSHqq/xUBff MDdDnV5i+9H4tVU+S0gIms9A5gbbT9D5LNPkzWPLBIvyIud5QSkUDfiRf7T5V/bQbg50 S8D1lkrwkdYQdzNx0CnkcRG08tvhfCEX/eV03FRz37df8u3eflXTgGKYBavc5XG33NCh Sk70zjtPZHMO/yD9ctcTLLx9yaKv3Gb45tf2kUu2zqFgDagTEsi1zZ/Y2ieLgaXbdSdO tROJy7mrxMIgPwvFUtuNbxW3Gx+a+Ar1iN8D4W3sDpbawFXw4JYQQsOtxNA7Mn1zoElR 0hgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=iFWd2m5XWAIUBukAvtG87ESkORevoEKwbahoShbsHGs=; b=OJKL//VJkdEQxoGuVVpVM4CQm8Yw2s51wIMZ2q9u2FoC7QVRgwEAAwFXNYmwrPqj50 Hkd50Jy1FkJ/+a89eaUOaUrxOxKrup78oDKxrCc2ZMFXcdmYqO1fTHNSojvO6gEDDj2I M6za9YQd2sC7ysCtUQzDJ0CT3I7YE+ZbhSfbI7Vejz8zn7hD3hNIRHAzuzI9VNC/uBh/ dLORGSotJ0ArJ1ppe7mZKGNDCZ+0ORzoen9zUNgFE4oIX0huwHdFqJkY4RKGF8cJBzSn QmMX7X6P3ngeb4q0iVVyLJt9mQI3RAZlSTCtGstvYWp/o0goNdjVLRL+JYKQvW2T0rHF YJ3g== X-Gm-Message-State: ANoB5pnTPHm5nMBun6KxrYo8F7AbfxjbbLXl2Vk8Wr9QDim7G/bhBO5e EdUtzOL4Eb+vTOtSGyNFpcMTRA== X-Google-Smtp-Source: AA0mqf7u3FO6mqMqL/O/9MD1mYQ8T/xRPY8vSC+lEwCmp+D+mRgb+hzX8+tpF096sntwINEzwHms9Q== X-Received: by 2002:a2e:7310:0:b0:277:d86:a36d with SMTP id o16-20020a2e7310000000b002770d86a36dmr4258270ljc.288.1668441215396; Mon, 14 Nov 2022 07:53:35 -0800 (PST) Received: from [192.168.31.208] ([194.29.137.22]) by smtp.gmail.com with ESMTPSA id h31-20020a0565123c9f00b00498f00420e9sm1857160lfv.194.2022.11.14.07.53.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 07:53:34 -0800 (PST) Message-ID: <12578e05-ced9-e5f7-7922-0af2f2159333@linaro.org> Date: Mon, 14 Nov 2022 16:53:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 1/9] dt-bindings: arm-smmu: Allow up to 3 power-domains To: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: patches@linaro.org, Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221114104222.36329-1-konrad.dybcio@linaro.org> <20221114104222.36329-2-konrad.dybcio@linaro.org> <6fa8e3ea-2113-d930-96bc-3726d53e5bcd@linaro.org> <0121fc03-b027-7659-5e6e-b42089c9888d@linaro.org> From: Konrad Dybcio In-Reply-To: <0121fc03-b027-7659-5e6e-b42089c9888d@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/11/2022 14:00, Krzysztof Kozlowski wrote: > On 14/11/2022 12:17, Konrad Dybcio wrote: >> On 14/11/2022 12:01, Krzysztof Kozlowski wrote: >>> On 14/11/2022 11:42, Konrad Dybcio wrote: >>>> Some SMMUs require that a vote is held on as much as 3 separate PDs >>>> (hello Qualcomm). Allow it in bindings. >>>> >>>> Signed-off-by: Konrad Dybcio >>>> --- >>>> Changes since v1: >>>> - Add minItems >>>> >>>> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>>> index 9066e6df1ba1..82bc696de662 100644 >>>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>>> @@ -159,7 +159,8 @@ properties: >>>> through the TCU's programming interface. >>>> >>>> power-domains: >>>> - maxItems: 1 >>>> + minItems: 0 >>> It cannot be 0. >>> >>> minItems: 1 >>> >>> Anyway you still need to restrict it per variant, as I said in previous >>> version. >> Hm.. I'm not entirely sure what you mean.. Should I add a list of >> compatibles > Yes and limit it to maxItems: 1 for "else". I tried adding:   - if:       properties:         compatible:           contains:             enum:               - qcom,sm6375-smmu-500     then:       properties:         power-domains:           minItems: 3           maxItems: 3     else:       properties:         power-domains:           maxItems: 1 Right under the nvidia reg if-else in the allOf, but dtbs_check throws errors like: /home/konrad/linux/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dtb: iommu@5040000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+' Any clues as to why? Konrad > >> that are allowed to have 3 power-domains and leave it as it was before >> in the >> 'else' case? > Best regards, > Krzysztof >