From: Krzysztof Kozlowski <krzk@kernel.org>
To: Markus Probst <markus.probst@posteo.de>
Cc: "Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Lee Jones" <lee@kernel.org>, "Pavel Machek" <pavel@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v7 2/2] dt-bindings: embedded-controller: Add synology microp devices
Date: Sun, 12 Apr 2026 15:22:51 +0200 [thread overview]
Message-ID: <125cad6c-fb58-4498-a967-41778f6f91f6@kernel.org> (raw)
In-Reply-To: <485ab9e829e902e3f29172059be8c3203062d06b.camel@posteo.de>
On 12/04/2026 15:21, Markus Probst wrote:
> On Sun, 2026-04-12 at 10:26 +0200, Krzysztof Kozlowski wrote:
>> On Sat, Apr 11, 2026 at 05:27:35PM +0200, Markus Probst wrote:
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - synology,ds923p-microp
>>> + - synology,ds918p-microp
>>> + - synology,ds214play-microp
>>> + - synology,ds225p-microp
>>> + - synology,ds425p-microp
>>> + - synology,ds710p-microp
>>> + - synology,ds1010p-microp
>>> + - synology,ds723p-microp
>>> + - synology,ds1522p-microp
>>> + - synology,rs422p-microp
>>> + - synology,ds725p-microp
>>> + - synology,ds118-microp
>>> + - synology,ds124-microp
>>> + - synology,ds223-microp
>>> + - synology,ds223j-microp
>>> + - synology,ds1823xsp-microp
>>> + - synology,rs822p-microp
>>> + - synology,rs1221p-microp
>>> + - synology,rs1221rpp-microp
>>> + - synology,ds925p-microp
>>> + - synology,ds1525p-microp
>>> + - synology,ds1825p-microp
>>
>> Previous comment is not resolved. For example you stated that ds723p is
>> compatible with ds725p, so this should be expressed.
> Using this expression?
>
> properties:
> compatible:
> oneOf:
> - enum:
> - synology,ds923p-microp
> - synology,ds1522p-microp
> - enum:
> - synology,ds918p-microp
> - synology,ds415p-microp
> - const: synology,ds214play-microp
> ...
> ?
> If so shall there each be a description?
No, you changed nothing. You need fallbacks, please read example-schema
or DTS101 slides.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-04-12 13:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 15:27 [PATCH v7 0/2] Introduce Synology Microp driver Markus Probst via B4 Relay
2026-04-11 15:27 ` [PATCH v7 1/2] platform: Add initial synology microp driver Markus Probst via B4 Relay
2026-04-11 16:55 ` Onur Özkan
2026-04-11 15:27 ` [PATCH v7 2/2] dt-bindings: embedded-controller: Add synology microp devices Markus Probst via B4 Relay
2026-04-12 8:26 ` Krzysztof Kozlowski
2026-04-12 13:21 ` Markus Probst
2026-04-12 13:22 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=125cad6c-fb58-4498-a967-41778f6f91f6@kernel.org \
--to=krzk@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=pavel@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox