From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8971533D6CA; Sun, 12 Apr 2026 13:23:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776000183; cv=none; b=EDx0giIr4664KP6FEHgfZyzmignbbsiMA5TWsxfxcyYnxUBOTvCNz4qgeUVH7Wsu9Si6IWk8uKUB6/K2OhGxUX6iNUpcizIAaHj+wKIe2af7tmTJXTxo2roZt1aQEOIEvega6f8VXfiUgqpE0MQ+dJ46WgXGAsPTIgL8pMFEfEU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776000183; c=relaxed/simple; bh=aYHqWJYLBiMXrDvtCOwuoP3WgzDcSKZ3t2fT5JRVxmI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SzZNfXH+0SjaAgZ0OHHtxZavuwpOB+AxXwNTNeirT/6LBi47yfFf/BqqiQlrKLjVuem1zkTocTXQtphdQsVB1ZW9tFRHykWpbNjkjSUxsRyC4Sxgs66X5b7DByO/zyMa+Sv7GBdyEW2EmtgshHI9Z9O6nX0hyCJxGLlDHOvBSH0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BhRJKm7J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BhRJKm7J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C653AC19424; Sun, 12 Apr 2026 13:22:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776000183; bh=aYHqWJYLBiMXrDvtCOwuoP3WgzDcSKZ3t2fT5JRVxmI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BhRJKm7JyCu2kDZeR6utCxxXiTnkqzdEdkbNPdbrvkqhiFIgT3EzWOFQS6J9lpLIk Nw1i78o3a6XFllRd5th6ZEaUe0lynNoN1diC1iU0SqyjyF9bi71K7aeESBtQ4uS0ae r2sy8fTq47NsPGOJ1t+kKqY0afvNsMBlFim8QrmRgUsQf42yJAT640gHC30OzBP6Ra HTITde693ewpS6iypVIQGASZA6NoyRiSSokXdV1atxlZ717S6TOk3hCgPLbsyZM2hm L8OLt4STnZ9Cp/QNR3m+qQ4AsbUjS/MDnoywgIrYvLFIIoeyxRy2wfLQYuckjO6bRA lNy2bIh1QqZpw== Message-ID: <125cad6c-fb58-4498-a967-41778f6f91f6@kernel.org> Date: Sun, 12 Apr 2026 15:22:51 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/2] dt-bindings: embedded-controller: Add synology microp devices To: Markus Probst Cc: Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Lee Jones , Pavel Machek , Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org References: <20260411-synology_microp_initial-v7-0-9a3a094e763a@posteo.de> <20260411-synology_microp_initial-v7-2-9a3a094e763a@posteo.de> <20260412-cuddly-taipan-of-reputation-1cafe0@quoll> <485ab9e829e902e3f29172059be8c3203062d06b.camel@posteo.de> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <485ab9e829e902e3f29172059be8c3203062d06b.camel@posteo.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/04/2026 15:21, Markus Probst wrote: > On Sun, 2026-04-12 at 10:26 +0200, Krzysztof Kozlowski wrote: >> On Sat, Apr 11, 2026 at 05:27:35PM +0200, Markus Probst wrote: >>> +properties: >>> + compatible: >>> + enum: >>> + - synology,ds923p-microp >>> + - synology,ds918p-microp >>> + - synology,ds214play-microp >>> + - synology,ds225p-microp >>> + - synology,ds425p-microp >>> + - synology,ds710p-microp >>> + - synology,ds1010p-microp >>> + - synology,ds723p-microp >>> + - synology,ds1522p-microp >>> + - synology,rs422p-microp >>> + - synology,ds725p-microp >>> + - synology,ds118-microp >>> + - synology,ds124-microp >>> + - synology,ds223-microp >>> + - synology,ds223j-microp >>> + - synology,ds1823xsp-microp >>> + - synology,rs822p-microp >>> + - synology,rs1221p-microp >>> + - synology,rs1221rpp-microp >>> + - synology,ds925p-microp >>> + - synology,ds1525p-microp >>> + - synology,ds1825p-microp >> >> Previous comment is not resolved. For example you stated that ds723p is >> compatible with ds725p, so this should be expressed. > Using this expression? > > properties: > compatible: > oneOf: > - enum: > - synology,ds923p-microp > - synology,ds1522p-microp > - enum: > - synology,ds918p-microp > - synology,ds415p-microp > - const: synology,ds214play-microp > ... > ? > If so shall there each be a description? No, you changed nothing. You need fallbacks, please read example-schema or DTS101 slides. Best regards, Krzysztof