Devicetree
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: michal.simek-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH] of: Fix comparison of "compatible" properties
Date: Thu, 18 Mar 2010 17:25:45 +1100	[thread overview]
Message-ID: <1268893545.2335.221.camel@pasglop> (raw)
In-Reply-To: <20100317.231847.112586488.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>

On Wed, 2010-03-17 at 23:18 -0700, David Miller wrote:
> > It's not quite right to do partial name match. Entries in a
> compatible
> > list are meant to be matched whole. If a device is compatible with
> both
> > "foo" and "foo1", then the device should have both strings in its
> > "compatible" property.
> > 
> > Signed-off-by: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
> >       (for patch description)
> > Signed-off-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> 
> Acked-by: David S. Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>

BTW. While at it... sparc still has it's override here to do partial
match (strncmp iirc). Do you rely on it ? Or do you do that only to be
case insensitive and the "n" is a result of history ?

Cheers,
Ben 

  parent reply	other threads:[~2010-03-18  6:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18  1:01 [PATCH] of: Fix comparison of "compatible" properties Grant Likely
2010-03-18  6:18 ` David Miller
     [not found]   ` <20100317.231847.112586488.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-03-18  6:25     ` Benjamin Herrenschmidt [this message]
2010-03-18  7:49 ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268893545.2335.221.camel@pasglop \
    --to=benh-xvmvhmargas8u2djnn8i7kb+6bgklq7r@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=michal.simek-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox