From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v1 1/2] arm64: dts: rockchip: add rk3328 i2s nodes Date: Sat, 29 Jul 2017 23:09:41 +0200 Message-ID: <12755546.8f2g0BVaYa@phil> References: <1501143365-76104-1-git-send-email-sugar.zhang@rock-chips.com> <1501143365-76104-2-git-send-email-sugar.zhang@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1501143365-76104-2-git-send-email-sugar.zhang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sugar Zhang Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Liang Chen , Shawn Lin , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Am Donnerstag, 27. Juli 2017, 16:16:03 CEST schrieb Sugar Zhang: > This patch add the i2s dt nodes for rk3328. > > Signed-off-by: Sugar Zhang > --- > > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 33 ++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > index 0be96ce..f1a284b 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > @@ -156,6 +156,39 @@ > clock-output-names = "xin24m"; > }; > > + i2s0: i2s@ff000000 { > + compatible = "rockchip,rk3328-i2s", "rockchip,rk3066-i2s"; It looks like the rockchip,rk3328-i2s compatible is missing in the binding documentation (Documentation/devicetree/bindings/sound/rockchip-i2s.txt) Send a patch adding it first please. Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html