Re: [PATCH 3/3] of: Remove unused of_find_device_by_phandle()

[Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>]

On Wed, 2010-07-14 at 17:31 -0600, Grant Likely wrote:
> Signed-off-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>

Acked-by: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>

> ---
>  arch/microblaze/include/asm/of_platform.h |    2 --
>  arch/microblaze/kernel/of_platform.c      |   18 ------------------
>  arch/powerpc/include/asm/of_platform.h    |    2 --
>  arch/powerpc/kernel/of_platform.c         |   19 -------------------
>  4 files changed, 0 insertions(+), 41 deletions(-)
> 
> diff --git a/arch/microblaze/include/asm/of_platform.h b/arch/microblaze/include/asm/of_platform.h
> index 625003f..353d8f6 100644
> --- a/arch/microblaze/include/asm/of_platform.h
> +++ b/arch/microblaze/include/asm/of_platform.h
> @@ -14,8 +14,6 @@
>  /* This is just here during the transition */
>  #include <linux/of_platform.h>
>  
> -extern struct of_device *of_find_device_by_phandle(phandle ph);
> -
>  extern void of_instantiate_rtc(void);
>  
>  #endif /* _ASM_MICROBLAZE_OF_PLATFORM_H */
> diff --git a/arch/microblaze/kernel/of_platform.c b/arch/microblaze/kernel/of_platform.c
> index 33212bb..80c9c49 100644
> --- a/arch/microblaze/kernel/of_platform.c
> +++ b/arch/microblaze/kernel/of_platform.c
> @@ -63,21 +63,3 @@ struct of_device *of_find_device_by_node(struct device_node *np)
>  	return NULL;
>  }
>  EXPORT_SYMBOL(of_find_device_by_node);
> -
> -static int of_dev_phandle_match(struct device *dev, void *data)
> -{
> -	phandle *ph = data;
> -	return to_of_device(dev)->dev.of_node->phandle == *ph;
> -}
> -
> -struct of_device *of_find_device_by_phandle(phandle ph)
> -{
> -	struct device *dev;
> -
> -	dev = bus_find_device(&platform_bus_type,
> -			      NULL, &ph, of_dev_phandle_match);
> -	if (dev)
> -		return to_of_device(dev);
> -	return NULL;
> -}
> -EXPORT_SYMBOL(of_find_device_by_phandle);
> diff --git a/arch/powerpc/include/asm/of_platform.h b/arch/powerpc/include/asm/of_platform.h
> index b37d2dc..d506aa6 100644
> --- a/arch/powerpc/include/asm/of_platform.h
> +++ b/arch/powerpc/include/asm/of_platform.h
> @@ -11,8 +11,6 @@
>   *
>   */
>  
> -extern struct of_device *of_find_device_by_phandle(phandle ph);
> -
>  extern void of_instantiate_rtc(void);
>  
>  #endif	/* _ASM_POWERPC_OF_PLATFORM_H */
> diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c
> index a3d7154..b093d4b 100644
> --- a/arch/powerpc/kernel/of_platform.c
> +++ b/arch/powerpc/kernel/of_platform.c
> @@ -68,25 +68,6 @@ struct of_device *of_find_device_by_node(struct device_node *np)
>  }
>  EXPORT_SYMBOL(of_find_device_by_node);
>  
> -static int of_dev_phandle_match(struct device *dev, void *data)
> -{
> -	phandle *ph = data;
> -	return to_of_device(dev)->dev.of_node->phandle == *ph;
> -}
> -
> -struct of_device *of_find_device_by_phandle(phandle ph)
> -{
> -	struct device *dev;
> -
> -	dev = bus_find_device(&platform_bus_type,
> -			      NULL, &ph, of_dev_phandle_match);
> -	if (dev)
> -		return to_of_device(dev);
> -	return NULL;
> -}
> -EXPORT_SYMBOL(of_find_device_by_phandle);
> -
> -
>  #ifdef CONFIG_PPC_OF_PLATFORM_PCI
>  
>  /* The probing of PCI controllers from of_platform is currently