[PATCH 0/2] Add HDMI support to iwg22d

[PATCH 0/2] Add HDMI support to iwg22d

[Fabrizio Castro]

Hello,

this series aims to add HDMI support to iWave RZ/G1E (R8A7745) board.
This series has been tested against renesas-devel-20171106-v4.14-rc8.

Fabrizio Castro (2):
  ARM: dts: r8a7745: Add DU support
  ARM: dts: iwg22d-sodimm-dbhd-ca: Add HDMI video output

 .../arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts | 85 ++++++++++++++++++++++
 arch/arm/boot/dts/r8a7745.dtsi                     | 27 +++++++
 2 files changed, 112 insertions(+)

-- 
2.7.4

[PATCH 1/2] ARM: dts: r8a7745: Add DU support

[Fabrizio Castro]

Add du node to r8a7745 SoC DT. Boards that want to enable the DU
need to specify the output topology.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm/boot/dts/r8a7745.dtsi | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi
index 846c27a..53eb1ce4 100644
--- a/arch/arm/boot/dts/r8a7745.dtsi
+++ b/arch/arm/boot/dts/r8a7745.dtsi
@@ -821,6 +821,33 @@
 			status = "disabled";
 		};
 
+		du: display@feb00000 {
+			compatible = "renesas,du-r8a7745";
+			reg = <0 0xfeb00000 0 0x40000>;
+			reg-names = "du";
+			interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>;
+			clock-names = "du.0", "du.1";
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					du_out_rgb0: endpoint {
+					};
+				};
+				port@1 {
+					reg = <1>;
+					du_out_rgb1: endpoint {
+					};
+				};
+			};
+		};
+
 		msiof0: spi@e6e20000 {
 			compatible = "renesas,msiof-r8a7745",
 				     "renesas,rcar-gen2-msiof";
-- 
2.7.4

Re: [PATCH 1/2] ARM: dts: r8a7745: Add DU support

[Laurent Pinchart]

Hi Fabrizio,

Thank you for the patch.

On Monday, 6 November 2017 20:26:53 EET Fabrizio Castro wrote:
> Add du node to r8a7745 SoC DT. Boards that want to enable the DU
> need to specify the output topology.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/boot/dts/r8a7745.dtsi | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi
> index 846c27a..53eb1ce4 100644
> --- a/arch/arm/boot/dts/r8a7745.dtsi
> +++ b/arch/arm/boot/dts/r8a7745.dtsi
> @@ -821,6 +821,33 @@
>  			status = "disabled";
>  		};
> 
> +		du: display@feb00000 {
> +			compatible = "renesas,du-r8a7745";
> +			reg = <0 0xfeb00000 0 0x40000>;
> +			reg-names = "du";
> +			interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>;
> +			clock-names = "du.0", "du.1";
> +			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					du_out_rgb0: endpoint {
> +					};
> +				};
> +				port@1 {
> +					reg = <1>;
> +					du_out_rgb1: endpoint {
> +					};
> +				};
> +			};
> +		};
> +
>  		msiof0: spi@e6e20000 {
>  			compatible = "renesas,msiof-r8a7745",
>  				     "renesas,rcar-gen2-msiof";


-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/2] ARM: dts: r8a7745: Add DU support

[Simon Horman]

On Tue, Nov 07, 2017 at 06:05:37AM +0200, Laurent Pinchart wrote:
> Hi Fabrizio,
> 
> Thank you for the patch.
> 
> On Monday, 6 November 2017 20:26:53 EET Fabrizio Castro wrote:
> > Add du node to r8a7745 SoC DT. Boards that want to enable the DU
> > need to specify the output topology.
> > 
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> > ---
> >  arch/arm/boot/dts/r8a7745.dtsi | 27 +++++++++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi
> > index 846c27a..53eb1ce4 100644
> > --- a/arch/arm/boot/dts/r8a7745.dtsi
> > +++ b/arch/arm/boot/dts/r8a7745.dtsi
> > @@ -821,6 +821,33 @@
> >  			status = "disabled";
> >  		};
> > 
> > +		du: display@feb00000 {
> > +			compatible = "renesas,du-r8a7745";

Hi,

could you provide some information on the status of upstreaming
the binding used above?

Re: [PATCH 1/2] ARM: dts: r8a7745: Add DU support

[Laurent Pinchart]

Hi Simon,

On Wednesday, 8 November 2017 06:48:23 EET Simon Horman wrote:
> On Tue, Nov 07, 2017 at 06:05:37AM +0200, Laurent Pinchart wrote:
> > Hi Fabrizio,
> > 
> > Thank you for the patch.
> > 
> > On Monday, 6 November 2017 20:26:53 EET Fabrizio Castro wrote:
> > > Add du node to r8a7745 SoC DT. Boards that want to enable the DU
> > > need to specify the output topology.
> > > 
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> > > ---
> > > 
> > >  arch/arm/boot/dts/r8a7745.dtsi | 27 +++++++++++++++++++++++++++
> > >  1 file changed, 27 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/r8a7745.dtsi
> > > b/arch/arm/boot/dts/r8a7745.dtsi index 846c27a..53eb1ce4 100644
> > > --- a/arch/arm/boot/dts/r8a7745.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7745.dtsi
> > > @@ -821,6 +821,33 @@
> > > 
> > >  			status = "disabled";
> > >  		
> > >  		};
> > > 
> > > +		du: display@feb00000 {
> > > +			compatible = "renesas,du-r8a7745";
> 
> Hi,
> 
> could you provide some information on the status of upstreaming
> the binding used above?

I'll send a pull request for v4.16, it's too late for v4.15.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/2] ARM: dts: r8a7745: Add DU support

[Simon Horman]

On Thu, Nov 09, 2017 at 11:31:25AM +0200, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Wednesday, 8 November 2017 06:48:23 EET Simon Horman wrote:
> > On Tue, Nov 07, 2017 at 06:05:37AM +0200, Laurent Pinchart wrote:
> > > Hi Fabrizio,
> > > 
> > > Thank you for the patch.
> > > 
> > > On Monday, 6 November 2017 20:26:53 EET Fabrizio Castro wrote:
> > > > Add du node to r8a7745 SoC DT. Boards that want to enable the DU
> > > > need to specify the output topology.
> > > > 
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> > > > Reviewed-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> > > 
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
> > > 
> > > > ---
> > > > 
> > > >  arch/arm/boot/dts/r8a7745.dtsi | 27 +++++++++++++++++++++++++++
> > > >  1 file changed, 27 insertions(+)
> > > > 
> > > > diff --git a/arch/arm/boot/dts/r8a7745.dtsi
> > > > b/arch/arm/boot/dts/r8a7745.dtsi index 846c27a..53eb1ce4 100644
> > > > --- a/arch/arm/boot/dts/r8a7745.dtsi
> > > > +++ b/arch/arm/boot/dts/r8a7745.dtsi
> > > > @@ -821,6 +821,33 @@
> > > > 
> > > >  			status = "disabled";
> > > >  		
> > > >  		};
> > > > 
> > > > +		du: display@feb00000 {
> > > > +			compatible = "renesas,du-r8a7745";
> > 
> > Hi,
> > 
> > could you provide some information on the status of upstreaming
> > the binding used above?
> 
> I'll send a pull request for v4.16, it's too late for v4.15.

Thanks, I'm happy with patches in that stage of being upstreamed
as the basis for accepting these patches. I'll see about doing so.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: r8a7745: Add DU support

[Simon Horman]

On Fri, Nov 10, 2017 at 09:32:49AM +0100, Simon Horman wrote:
> On Thu, Nov 09, 2017 at 11:31:25AM +0200, Laurent Pinchart wrote:
> > Hi Simon,
> > 
> > On Wednesday, 8 November 2017 06:48:23 EET Simon Horman wrote:
> > > On Tue, Nov 07, 2017 at 06:05:37AM +0200, Laurent Pinchart wrote:
> > > > Hi Fabrizio,
> > > > 
> > > > Thank you for the patch.
> > > > 
> > > > On Monday, 6 November 2017 20:26:53 EET Fabrizio Castro wrote:
> > > > > Add du node to r8a7745 SoC DT. Boards that want to enable the DU
> > > > > need to specify the output topology.
> > > > > 
> > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > > > 
> > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > > 
> > > > > ---
> > > > > 
> > > > >  arch/arm/boot/dts/r8a7745.dtsi | 27 +++++++++++++++++++++++++++
> > > > >  1 file changed, 27 insertions(+)
> > > > > 
> > > > > diff --git a/arch/arm/boot/dts/r8a7745.dtsi
> > > > > b/arch/arm/boot/dts/r8a7745.dtsi index 846c27a..53eb1ce4 100644
> > > > > --- a/arch/arm/boot/dts/r8a7745.dtsi
> > > > > +++ b/arch/arm/boot/dts/r8a7745.dtsi
> > > > > @@ -821,6 +821,33 @@
> > > > > 
> > > > >  			status = "disabled";
> > > > >  		
> > > > >  		};
> > > > > 
> > > > > +		du: display@feb00000 {
> > > > > +			compatible = "renesas,du-r8a7745";
> > > 
> > > Hi,
> > > 
> > > could you provide some information on the status of upstreaming
> > > the binding used above?
> > 
> > I'll send a pull request for v4.16, it's too late for v4.15.
> 
> Thanks, I'm happy with patches in that stage of being upstreamed
> as the basis for accepting these patches. I'll see about doing so.

Done, I have applied this for v4.16.

[PATCH 2/2] ARM: dts: iwg22d-sodimm-dbhd-ca: Add HDMI video output

[Fabrizio Castro]

This patch enables the HDMI interface found on the expansion board.

Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
Reviewed-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
---
 .../arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts | 85 ++++++++++++++++++++++
 1 file changed, 85 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts
index f925388..a8a4ec8 100644
--- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts
+++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts
@@ -20,6 +20,38 @@
 		serial4 = &scif5;
 		serial6 = &hscif2;
 	};
+
+	cec_clock: cec-clock {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <12000000>;
+	};
+
+	hdmi-out {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con: endpoint {
+				remote-endpoint = <&adv7511_out>;
+			};
+		};
+	};
+};
+
+&du {
+	pinctrl-0 = <&du0_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+
+	ports {
+		port@0 {
+			endpoint {
+				remote-endpoint = <&adv7511_in>;
+			};
+		};
+	};
 };
 
 &hscif2 {
@@ -29,12 +61,65 @@
 	status = "okay";
 };
 
+&i2c1 {
+	pinctrl-0 = <&i2c1_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+	clock-frequency = <400000>;
+
+	hdmi@39 {
+		compatible = "adi,adv7511w";
+		reg = <0x39>;
+		interrupt-parent = <&gpio1>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+		clocks = <&cec_clock>;
+		clock-names = "cec";
+		pd-gpios = <&gpio2 24 GPIO_ACTIVE_HIGH>;
+
+		adi,input-depth = <8>;
+		adi,input-colorspace = "rgb";
+		adi,input-clock = "1x";
+		adi,input-style = <1>;
+		adi,input-justification = "evenly";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				adv7511_in: endpoint {
+					remote-endpoint = <&du_out_rgb0>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				adv7511_out: endpoint {
+					remote-endpoint = <&hdmi_con>;
+				};
+			};
+		};
+	};
+};
+
 &pfc {
+	du0_pins: du0 {
+		groups = "du0_rgb888", "du0_sync", "du0_disp", "du0_clk0_out";
+		function = "du0";
+	};
+
 	hscif2_pins: hscif2 {
 		groups = "hscif2_data";
 		function = "hscif2";
 	};
 
+	i2c1_pins: i2c1 {
+		groups = "i2c1_d";
+		function = "i2c1";
+	};
+
 	scif1_pins: scif1 {
 		groups = "scif1_data";
 		function = "scif1";
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ARM: dts: iwg22d-sodimm-dbhd-ca: Add HDMI video output

[Laurent Pinchart]

Hi Fabrizio,

Thank you for the patch.

On Monday, 6 November 2017 20:26:54 EET Fabrizio Castro wrote:
> This patch enables the HDMI interface found on the expansion board.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

Nothing strikes me as wrong, but I haven't checked the board's schematics, so

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  .../arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts | 85 +++++++++++++++++++
>  1 file changed, 85 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts
> b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts index
> f925388..a8a4ec8 100644
> --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts
> +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts
> @@ -20,6 +20,38 @@
>  		serial4 = &scif5;
>  		serial6 = &hscif2;
>  	};
> +
> +	cec_clock: cec-clock {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <12000000>;
> +	};
> +
> +	hdmi-out {
> +		compatible = "hdmi-connector";
> +		type = "a";
> +
> +		port {
> +			hdmi_con: endpoint {
> +				remote-endpoint = <&adv7511_out>;
> +			};
> +		};
> +	};
> +};
> +
> +&du {
> +	pinctrl-0 = <&du0_pins>;
> +	pinctrl-names = "default";
> +
> +	status = "okay";
> +
> +	ports {
> +		port@0 {
> +			endpoint {
> +				remote-endpoint = <&adv7511_in>;
> +			};
> +		};
> +	};
>  };
> 
>  &hscif2 {
> @@ -29,12 +61,65 @@
>  	status = "okay";
>  };
> 
> +&i2c1 {
> +	pinctrl-0 = <&i2c1_pins>;
> +	pinctrl-names = "default";
> +
> +	status = "okay";
> +	clock-frequency = <400000>;
> +
> +	hdmi@39 {
> +		compatible = "adi,adv7511w";
> +		reg = <0x39>;
> +		interrupt-parent = <&gpio1>;
> +		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +		clocks = <&cec_clock>;
> +		clock-names = "cec";
> +		pd-gpios = <&gpio2 24 GPIO_ACTIVE_HIGH>;
> +
> +		adi,input-depth = <8>;
> +		adi,input-colorspace = "rgb";
> +		adi,input-clock = "1x";
> +		adi,input-style = <1>;
> +		adi,input-justification = "evenly";
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;
> +				adv7511_in: endpoint {
> +					remote-endpoint = <&du_out_rgb0>;
> +				};
> +			};
> +
> +			port@1 {
> +				reg = <1>;
> +				adv7511_out: endpoint {
> +					remote-endpoint = <&hdmi_con>;
> +				};
> +			};
> +		};
> +	};
> +};
> +
>  &pfc {
> +	du0_pins: du0 {
> +		groups = "du0_rgb888", "du0_sync", "du0_disp", "du0_clk0_out";
> +		function = "du0";
> +	};
> +
>  	hscif2_pins: hscif2 {
>  		groups = "hscif2_data";
>  		function = "hscif2";
>  	};
> 
> +	i2c1_pins: i2c1 {
> +		groups = "i2c1_d";
> +		function = "i2c1";
> +	};
> +
>  	scif1_pins: scif1 {
>  		groups = "scif1_data";
>  		function = "scif1";


-- 
Regards,

Laurent Pinchart

Re: [PATCH 2/2] ARM: dts: iwg22d-sodimm-dbhd-ca: Add HDMI video output

[Simon Horman]

On Tue, Nov 07, 2017 at 06:13:01AM +0200, Laurent Pinchart wrote:
> Hi Fabrizio,
> 
> Thank you for the patch.
> 
> On Monday, 6 November 2017 20:26:54 EET Fabrizio Castro wrote:
> > This patch enables the HDMI interface found on the expansion board.
> > 
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> 
> Nothing strikes me as wrong, but I haven't checked the board's schematics, so
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks, I have applied this for v4.16.