From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3 5/7] ARM: brcmstb: add misc. DT bindings for brcm,brcmstb-* Date: Wed, 15 Jan 2014 18:15:10 +0100 Message-ID: <12927046.KPmoBiUFty@wuerfel> References: <1389743333-16741-1-git-send-email-marc.ceeeee@gmail.com> <1389743333-16741-6-git-send-email-marc.ceeeee@gmail.com> <20140115171155.GK25824@e106331-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20140115171155.GK25824-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Rutland Cc: Marc Carino , Christian Daudt , Florian Fainelli , Matt Porter , Russell King , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Wednesday 15 January 2014 17:11:55 Mark Rutland wrote: > > + > > +Further, a node with the following compatible string shall be defined: > > + > > + - compatible: "brcm,brcmstb-gen-ctrl-v1" > > It's probably better to say a brcmstb-gen-ctrl node (described below) > should be present, or you'll have two places to update the compatible > strings for each new variant... See my other reply on this node. The previous patch version had a different approach to these registers, and I suggested doing yet another one and using syscon. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html