devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonas Bonn <jonas-A9uVI2HLR7kOP4wsBPIw7w@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 3/3] i2c-ocores: add some device tree documentation
Date: Fri, 24 Dec 2010 10:38:57 +0100	[thread overview]
Message-ID: <1293183537.8652.4236.camel@satguru> (raw)
In-Reply-To: <20101224040017.GE2491-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>

> > +/*
> > + * Device tree configuration:
> > + *
> > + * Required properties:
> > + * - compatible      : "opencores,i2c-ocores"
> 
> I assume the i2c-ocore interface could end up changing in the future.
> This compatible value should have some form of version embedded into
> it.
> 

Unfortunately, versioning is currently one of OpenCores weak points.
This driver is based on specification version 0.9 and has implementation
version 1.16 according to source and SVN revision 76.  I've started an
internal discussion to try to standardize on something useful, but
there's no consensus, as of yet.  I could make something up here for the
compatible value, but I'd rather we find a consistent versioning scheme
that's tenable long-term.

I guess I'll have to sit on these patches for another cycle while we
think about this.  Of course, if you have any suggestions, let me know;
looking at other drivers, there doesn't seem to be a canonical way of
doing this...

Perhaps:  opencores,i2c-cores-0.9-76
(i.e. {driver}-{spec revision}-{implementation svn rev})

/Jonas

PS: Honestly not crazy about the name 'i2c-ocores' either as it doesn't
match the name of the upstream Verilog project which is called,
unfortunately, simply 'i2c'.  This driver, however, has been upstream
for a while so I guess we're stuck with it.

  parent reply	other threads:[~2010-12-24  9:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-24 16:26 i2c-ocores changes (version 2) Jonas Bonn
     [not found] ` <1290615982-1028-1-git-send-email-jonas-A9uVI2HLR7kOP4wsBPIw7w@public.gmane.org>
2010-11-24 16:26   ` [PATCH 1/3] i2c-ocores: Adapt for device tree Jonas Bonn
     [not found]     ` <1290615982-1028-2-git-send-email-jonas-A9uVI2HLR7kOP4wsBPIw7w@public.gmane.org>
2010-12-01  9:37       ` Walter Goossens
2011-01-04  1:05       ` Ben Dooks
2010-11-24 16:26   ` [PATCH 2/3] i2c-ocores: Use devres for resource allocation Jonas Bonn
2010-11-24 16:26   ` [PATCH 3/3] i2c-ocores: add some device tree documentation Jonas Bonn
     [not found]     ` <1290615982-1028-4-git-send-email-jonas-A9uVI2HLR7kOP4wsBPIw7w@public.gmane.org>
2010-12-24  4:00       ` Grant Likely
     [not found]         ` <20101224040017.GE2491-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-12-24  9:38           ` Jonas Bonn [this message]
2010-12-24 14:02             ` Peter Korsgaard
2010-12-24 20:06             ` Grant Likely
2010-12-06  4:33   ` i2c-ocores changes (version 2) Ben Dooks
     [not found]     ` <4CFC67AA.2080707-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
2010-12-24  4:03       ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1293183537.8652.4236.camel@satguru \
    --to=jonas-a9uvi2hlr7kop4wsbpiw7w@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).