From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Goud, Srinivas" <srinivas.goud@amd.com>, Rob Herring <robh@kernel.org>
Cc: "wg@grandegger.com" <wg@grandegger.com>,
"mkl@pengutronix.de" <mkl@pengutronix.de>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"git (AMD-Xilinx)" <git@amd.com>,
"Simek, Michal" <michal.simek@amd.com>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"appana.durga.rao@xilinx.com" <appana.durga.rao@xilinx.com>,
"naga.sureshkumar.relli@xilinx.com"
<naga.sureshkumar.relli@xilinx.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: can: xilinx_can: Add ECC property 'xlnx,has-ecc'
Date: Wed, 30 Aug 2023 09:13:00 +0200 [thread overview]
Message-ID: <12a0f531-851f-cd09-3d56-828e2aeccae3@linaro.org> (raw)
In-Reply-To: <PH8PR12MB6675C31C6D1DCD3281FE8A10E1E6A@PH8PR12MB6675.namprd12.prod.outlook.com>
On 30/08/2023 08:06, Goud, Srinivas wrote:
>>> +
>>> required:
>>> - compatible
>>> - reg
>>> @@ -137,6 +141,7 @@ examples:
>>> interrupts = <GIC_SPI 59 IRQ_TYPE_EDGE_RISING>;
>>> tx-fifo-depth = <0x40>;
>>> rx-fifo-depth = <0x40>;
>>> + xlnx,has-ecc
>>
>> Obviously not tested.
> Will fix it.
>
Fix it by fixing error or by testing? Can you do both?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-30 18:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 14:58 [PATCH v3 0/3] can: xilinx_can: Add ECC feature support Srinivas Goud
2023-08-28 14:58 ` [PATCH v3 1/3] dt-bindings: can: xilinx_can: Add ECC property 'xlnx,has-ecc' Srinivas Goud
2023-08-28 15:43 ` Rob Herring
2023-08-30 6:06 ` Goud, Srinivas
2023-08-30 7:13 ` Krzysztof Kozlowski [this message]
2023-08-30 7:45 ` Goud, Srinivas
2023-08-28 14:58 ` [PATCH v3 2/3] can: xilinx_can: Add ECC support Srinivas Goud
2023-08-28 14:58 ` [PATCH v3 3/3] can: xilinx_can: Add ethtool stats interface for ECC errors Srinivas Goud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12a0f531-851f-cd09-3d56-828e2aeccae3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=appana.durga.rao@xilinx.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=mkl@pengutronix.de \
--cc=naga.sureshkumar.relli@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=srinivas.goud@amd.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).