From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sibi Sankar <quic_sibis@quicinc.com>,
andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org
Cc: agross@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
konrad.dybcio@somainline.org, robimarko@gmail.com,
quic_gurus@quicinc.com, quic_rjendra@quicinc.com
Subject: Re: [PATCH V3 1/2] dt-bindings: firmware: qcom-scm: Add optional interrupt
Date: Tue, 18 Oct 2022 13:11:12 -0400 [thread overview]
Message-ID: <12d79669-6e8c-6cf8-2e32-d4e0e2e42f3d@linaro.org> (raw)
In-Reply-To: <1666086406-5452-2-git-send-email-quic_sibis@quicinc.com>
On 18/10/2022 05:46, Sibi Sankar wrote:
> From: Guru Das Srinagesh <quic_gurus@quicinc.com>
>
> Add an interrupt specification to the bindings to support the wait-queue
> feature.
>
> Signed-off-by: Guru Das Srinagesh <quic_gurus@quicinc.com>
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
>
> The interrupt property for scm firmware from a binding perspective is
> completely optional i.e. not all tz fw running in the wild on sm8450
> devices support this feature. The bootloader does the interrupt property
> addition on sm8450 devices with wait-queue support.
>
> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> index c5b76c9f7ad0..6483d76b2371 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> @@ -71,6 +71,11 @@ properties:
> '#reset-cells':
> const: 1
>
> + interrupts:
> + description:
> + The wait-queue interrupt that firmware raises as part of handshake
> + protocol to handle sleeping SCM calls.
You still miss here constraints... nothing improved. Just look at other
properties in this file.
maxItems:1
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-18 17:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 9:46 [PATCH V3 0/2] SCM: Add support for wait-queue aware firmware Sibi Sankar
2022-10-18 9:46 ` [PATCH V3 1/2] dt-bindings: firmware: qcom-scm: Add optional interrupt Sibi Sankar
2022-10-18 17:11 ` Krzysztof Kozlowski [this message]
2022-10-19 6:14 ` Sibi Sankar
2022-10-18 9:46 ` [PATCH V3 2/2] firmware: qcom: scm: Add wait-queue handling logic Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12d79669-6e8c-6cf8-2e32-d4e0e2e42f3d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_gurus@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).