From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: nick.hudson@gmx.co.uk, Florian Fainelli <f.fainelli@gmail.com>
Cc: Nick Hudson <skrll@netbsd.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: bcm2835-rpi-zero-w: Add missing pinctrl name
Date: Wed, 11 Mar 2020 12:28:43 +0100 [thread overview]
Message-ID: <12f35cc38b87dfe27f0786c931d4434b0fecb3d8.camel@suse.de> (raw)
In-Reply-To: <20200310182537.8156-1-nick.hudson@gmx.co.uk>
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
On Tue, 2020-03-10 at 18:25 +0000, nick.hudson@gmx.co.uk wrote:
> From: Nick Hudson <nick.hudson@gmx.co.uk>
>
> Define the sdhci pinctrl state as "default" so it gets applied
> correctly and to match all other RPis.
>
> Fixes: 2c7c040c73e9 ("ARM: dts: bcm2835: Add Raspberry Pi Zero W")
>
> Signed-off-by: Nick Hudson <skrll@netbsd.org>
I think this one has everything right. As a nitpick, there is no need to add a
space between the Fixes tag and the Signed-off-by tag, but it's OK as is.
Florian, can we channel this as a fix for v5.6 or are we too late?
Regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-11 11:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 18:25 [PATCH] ARM: bcm2835-rpi-zero-w: Add missing pinctrl name nick.hudson
2020-03-11 11:28 ` Nicolas Saenz Julienne [this message]
2020-03-11 16:37 ` Florian Fainelli
2020-03-11 16:39 ` Nicolas Saenz Julienne
2020-03-11 21:24 ` Florian Fainelli
2020-03-11 21:26 ` Florian Fainelli
-- strict thread matches above, loose matches on Subject: below --
2020-03-12 9:03 Nick Hudson
2020-03-12 20:06 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12f35cc38b87dfe27f0786c931d4434b0fecb3d8.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=nick.hudson@gmx.co.uk \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=skrll@netbsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).