From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ritesh Harjani Subject: Re: [PATCH v5 05/12] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback Date: Mon, 10 Oct 2016 16:35:15 +0530 Message-ID: <1300609b-161c-43bd-93da-c440d9bd45a3@codeaurora.org> References: <1475678440-3525-1-git-send-email-riteshh@codeaurora.org> <1475678440-3525-6-git-send-email-riteshh@codeaurora.org> <54b602df-9c23-dc81-fd51-d04b441b99c0@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54b602df-9c23-dc81-fd51-d04b441b99c0@intel.com> Sender: linux-mmc-owner@vger.kernel.org To: Adrian Hunter , ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, shawn.lin@rock-chips.com Cc: david.brown@linaro.org, andy.gross@linaro.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, georgi.djakov@linaro.org, alex.lemberg@sandisk.com, mateusz.nowak@intel.com, Yuliy.Izrailov@sandisk.com, asutoshd@codeaurora.org, david.griego@linaro.org, stummala@codeaurora.org, venkatg@codeaurora.org, sboyd@codeaurora.org, bjorn.andersson@linaro.org, pramod.gurav@linaro.org List-Id: devicetree@vger.kernel.org Hi Adrian, On 10/10/2016 3:16 PM, Adrian Hunter wrote: > On 05/10/16 17:40, Ritesh Harjani wrote: >> This add get_min_clock() and get_max_clock() callback >> for sdhci-msm. sdhci-msm min/max clocks may be different >> hence implement these callbacks. >> >> Signed-off-by: Sahitya Tummala >> Signed-off-by: Ritesh Harjani >> --- >> drivers/mmc/host/sdhci-msm.c | 29 +++++++++++++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c >> index 042ecb2..4e17201 100644 >> --- a/drivers/mmc/host/sdhci-msm.c >> +++ b/drivers/mmc/host/sdhci-msm.c >> @@ -68,6 +68,7 @@ >> #define CORE_VENDOR_SPEC_CAPABILITIES0 0x11c >> >> #define TCXO_FREQ 19200000 >> +#define SDHCI_MSM_MIN_CLOCK 400000 >> >> #define CDR_SELEXT_SHIFT 20 >> #define CDR_SELEXT_MASK (0xf << CDR_SELEXT_SHIFT) >> @@ -561,6 +562,32 @@ static irqreturn_t sdhci_msm_pwr_irq(int irq, void *data) >> return IRQ_HANDLED; >> } >> >> +static unsigned int sdhci_msm_get_max_clock(struct sdhci_host *host) >> +{ >> + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); >> + struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host); >> + int count; >> + >> + if (msm_host->clk_table) { > > I don't know if DT allows empty arrays, but if it does, might not > msm_host->clk_table_sz be zero here. Sure, I will take care of this as mentioned in the response of previous patch 03. > >> + count = msm_host->clk_table_sz; >> + return msm_host->clk_table[count - 1]; >> + } else { > > 'else' is redundant here. Done. Will remove it. > >> + return clk_round_rate(msm_host->clk, ULONG_MAX); >> + } >> +} >> + >> +static unsigned int sdhci_msm_get_min_clock(struct sdhci_host *host) >> +{ >> + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); >> + struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host); >> + >> + if (msm_host->clk_table) { > > Same about possibility of msm_host->clk_table_sz being zero. Yes, as mentioned. Will take care of this. > >> + return msm_host->clk_table[0]; >> + } else { > > 'else' is redundant here. Done. > >> + return SDHCI_MSM_MIN_CLOCK; >> + } >> +} >> + >> static const struct of_device_id sdhci_msm_dt_match[] = { >> { .compatible = "qcom,sdhci-msm-v4" }, >> {}, >> @@ -572,6 +599,8 @@ static const struct sdhci_ops sdhci_msm_ops = { >> .platform_execute_tuning = sdhci_msm_execute_tuning, >> .reset = sdhci_reset, >> .set_clock = sdhci_set_clock, >> + .get_min_clock = sdhci_msm_get_min_clock, >> + .get_max_clock = sdhci_msm_get_max_clock, >> .set_bus_width = sdhci_set_bus_width, >> .set_uhs_signaling = sdhci_msm_set_uhs_signaling, >> .voltage_switch = sdhci_msm_voltage_switch, >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >