From: Jeremy Kerr <jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH] dt/flattree: Fix return value of early_init_dt_scan_memory
Date: Wed, 20 Apr 2011 08:47:26 +0800 [thread overview]
Message-ID: <1303260446.28913.4.camel@pororo> (raw)
In-Reply-To: <1303225269-10092-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Hi Shawn,
> It fixes the return value of funciont early_init_dt_scan_memory on
> the success return path.
[In general, the changelog should explain why you're making this change,
not just re-iterate what the patch does. Does this fix a problem you
were seeing?]
With regards to this specific patch - I don't think this is correct; if
we return 1 here, we'll abort the of_scan_flat_dt loop after
successfully parsing one memory node, whereas machines may have multiple
nodes. This change will break booting on those machines.
Cheers,
Jeremy
next prev parent reply other threads:[~2011-04-20 0:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 15:01 [PATCH] dt/flattree: Fix return value of early_init_dt_scan_memory Shawn Guo
[not found] ` <1303225269-10092-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-04-20 0:47 ` Jeremy Kerr [this message]
2011-04-20 2:44 ` Grant Likely
2011-04-20 14:16 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303260446.28913.4.camel@pororo \
--to=jeremy.kerr-z7wlfzj8ewms+fvcfc7uqw@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
--cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).