* [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB
@ 2011-06-08 2:49 Prabhakar Kushwaha
[not found] ` <1307501379-3160-1-git-send-email-prabhakar-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Prabhakar Kushwaha @ 2011-06-08 2:49 UTC (permalink / raw)
To: linuxppc-dev, devicetree-discuss; +Cc: meet2prabhu, Prabhakar Kushwaha
ten-bit interface (TBI) module is part of SoC not board.
Move tbi entries from board related dts files to Si dts.
Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
---
Based upon http://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git (branch next)
arch/powerpc/boot/dts/p1020rdb.dts | 9 ---------
arch/powerpc/boot/dts/p1020rdb_camp_core0.dts | 8 --------
arch/powerpc/boot/dts/p1020si.dtsi | 6 +++++-
arch/powerpc/boot/dts/p2020rdb.dts | 8 --------
arch/powerpc/boot/dts/p2020rdb_camp_core0.dts | 8 --------
arch/powerpc/boot/dts/p2020si.dtsi | 6 +++++-
6 files changed, 10 insertions(+), 35 deletions(-)
diff --git a/arch/powerpc/boot/dts/p1020rdb.dts b/arch/powerpc/boot/dts/p1020rdb.dts
index d6a8ae4..a4e5d6c 100644
--- a/arch/powerpc/boot/dts/p1020rdb.dts
+++ b/arch/powerpc/boot/dts/p1020rdb.dts
@@ -211,14 +211,6 @@
};
};
- mdio@25000 {
-
- tbi0: tbi-phy@11 {
- reg = <0x11>;
- device_type = "tbi-phy";
- };
- };
-
enet0: ethernet@b0000 {
fixed-link = <1 1 1000 0 0>;
phy-connection-type = "rgmii-id";
@@ -227,7 +219,6 @@
enet1: ethernet@b1000 {
phy-handle = <&phy0>;
- tbi-handle = <&tbi0>;
phy-connection-type = "sgmii";
};
diff --git a/arch/powerpc/boot/dts/p1020rdb_camp_core0.dts b/arch/powerpc/boot/dts/p1020rdb_camp_core0.dts
index f0bf7f4..abab234 100644
--- a/arch/powerpc/boot/dts/p1020rdb_camp_core0.dts
+++ b/arch/powerpc/boot/dts/p1020rdb_camp_core0.dts
@@ -114,20 +114,12 @@
};
};
- mdio@25000 {
- tbi0: tbi-phy@11 {
- reg = <0x11>;
- device_type = "tbi-phy";
- };
- };
-
enet0: ethernet@b0000 {
status = "disabled";
};
enet1: ethernet@b1000 {
phy-handle = <&phy0>;
- tbi-handle = <&tbi0>;
phy-connection-type = "sgmii";
};
diff --git a/arch/powerpc/boot/dts/p1020si.dtsi b/arch/powerpc/boot/dts/p1020si.dtsi
index 5c5acb6..7844d2e 100644
--- a/arch/powerpc/boot/dts/p1020si.dtsi
+++ b/arch/powerpc/boot/dts/p1020si.dtsi
@@ -190,7 +190,10 @@
#size-cells = <0>;
compatible = "fsl,etsec2-tbi";
reg = <0x25000 0x1000 0xb1030 0x4>;
-
+ tbi0: tbi-phy@11 {
+ reg = <0x11>;
+ device_type = "tbi-phy";
+ };
};
enet0: ethernet@b0000 {
@@ -229,6 +232,7 @@
fsl,num_tx_queues = <0x8>;
local-mac-address = [ 00 00 00 00 00 00 ];
interrupt-parent = <&mpic>;
+ tbi-handle = <&tbi0>;
queue-group@0 {
#address-cells = <1>;
diff --git a/arch/powerpc/boot/dts/p2020rdb.dts b/arch/powerpc/boot/dts/p2020rdb.dts
index 1d7a05f..2941cbb 100644
--- a/arch/powerpc/boot/dts/p2020rdb.dts
+++ b/arch/powerpc/boot/dts/p2020rdb.dts
@@ -213,13 +213,6 @@
};
};
- mdio@25520 {
- tbi0: tbi-phy@11 {
- reg = <0x11>;
- device_type = "tbi-phy";
- };
- };
-
mdio@26520 {
status = "disabled";
};
@@ -243,7 +236,6 @@
};
enet1: ethernet@25000 {
- tbi-handle = <&tbi0>;
phy-handle = <&phy0>;
phy-connection-type = "sgmii";
};
diff --git a/arch/powerpc/boot/dts/p2020rdb_camp_core0.dts b/arch/powerpc/boot/dts/p2020rdb_camp_core0.dts
index fc8dddd..4641f3d 100644
--- a/arch/powerpc/boot/dts/p2020rdb_camp_core0.dts
+++ b/arch/powerpc/boot/dts/p2020rdb_camp_core0.dts
@@ -124,13 +124,6 @@
};
};
- mdio@25520 {
- tbi0: tbi-phy@11 {
- reg = <0x11>;
- device_type = "tbi-phy";
- };
- };
-
mdio@26520 {
status = "disabled";
};
@@ -140,7 +133,6 @@
};
enet1: ethernet@25000 {
- tbi-handle = <&tbi0>;
phy-handle = <&phy0>;
phy-connection-type = "sgmii";
diff --git a/arch/powerpc/boot/dts/p2020si.dtsi b/arch/powerpc/boot/dts/p2020si.dtsi
index 6def17f..9317075 100644
--- a/arch/powerpc/boot/dts/p2020si.dtsi
+++ b/arch/powerpc/boot/dts/p2020si.dtsi
@@ -235,6 +235,10 @@
#size-cells = <0>;
compatible = "fsl,gianfar-tbi";
reg = <0x26520 0x20>;
+ tbi0: tbi-phy@11 {
+ reg = <0x11>;
+ device_type = "tbi-phy";
+ };
};
mdio@26520 {
@@ -270,7 +274,7 @@
local-mac-address = [ 00 00 00 00 00 00 ];
interrupts = <35 2 36 2 40 2>;
interrupt-parent = <&mpic>;
-
+ tbi-handle = <&tbi0>;
};
enet2: ethernet@26000 {
--
1.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <1307501379-3160-1-git-send-email-prabhakar-KZfg59tc24xl57MIdRCFDg@public.gmane.org>]
* Re: [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB [not found] ` <1307501379-3160-1-git-send-email-prabhakar-KZfg59tc24xl57MIdRCFDg@public.gmane.org> @ 2011-06-08 14:57 ` Grant Likely 2011-06-22 11:34 ` Kumar Gala 1 sibling, 0 replies; 6+ messages in thread From: Grant Likely @ 2011-06-08 14:57 UTC (permalink / raw) To: Prabhakar Kushwaha Cc: meet2prabhu-Re5JQEeQqe8AvxtiuMwx3w, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ On Wed, Jun 08, 2011 at 08:19:39AM +0530, Prabhakar Kushwaha wrote: > ten-bit interface (TBI) module is part of SoC not board. > > Move tbi entries from board related dts files to Si dts. > > Signed-off-by: Prabhakar Kushwaha <prabhakar-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Looks okay to me. g. > --- > Based upon http://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git (branch next) > > arch/powerpc/boot/dts/p1020rdb.dts | 9 --------- > arch/powerpc/boot/dts/p1020rdb_camp_core0.dts | 8 -------- > arch/powerpc/boot/dts/p1020si.dtsi | 6 +++++- > arch/powerpc/boot/dts/p2020rdb.dts | 8 -------- > arch/powerpc/boot/dts/p2020rdb_camp_core0.dts | 8 -------- > arch/powerpc/boot/dts/p2020si.dtsi | 6 +++++- > 6 files changed, 10 insertions(+), 35 deletions(-) > > diff --git a/arch/powerpc/boot/dts/p1020rdb.dts b/arch/powerpc/boot/dts/p1020rdb.dts > index d6a8ae4..a4e5d6c 100644 > --- a/arch/powerpc/boot/dts/p1020rdb.dts > +++ b/arch/powerpc/boot/dts/p1020rdb.dts > @@ -211,14 +211,6 @@ > }; > }; > > - mdio@25000 { > - > - tbi0: tbi-phy@11 { > - reg = <0x11>; > - device_type = "tbi-phy"; > - }; > - }; > - > enet0: ethernet@b0000 { > fixed-link = <1 1 1000 0 0>; > phy-connection-type = "rgmii-id"; > @@ -227,7 +219,6 @@ > > enet1: ethernet@b1000 { > phy-handle = <&phy0>; > - tbi-handle = <&tbi0>; > phy-connection-type = "sgmii"; > > }; > diff --git a/arch/powerpc/boot/dts/p1020rdb_camp_core0.dts b/arch/powerpc/boot/dts/p1020rdb_camp_core0.dts > index f0bf7f4..abab234 100644 > --- a/arch/powerpc/boot/dts/p1020rdb_camp_core0.dts > +++ b/arch/powerpc/boot/dts/p1020rdb_camp_core0.dts > @@ -114,20 +114,12 @@ > }; > }; > > - mdio@25000 { > - tbi0: tbi-phy@11 { > - reg = <0x11>; > - device_type = "tbi-phy"; > - }; > - }; > - > enet0: ethernet@b0000 { > status = "disabled"; > }; > > enet1: ethernet@b1000 { > phy-handle = <&phy0>; > - tbi-handle = <&tbi0>; > phy-connection-type = "sgmii"; > }; > > diff --git a/arch/powerpc/boot/dts/p1020si.dtsi b/arch/powerpc/boot/dts/p1020si.dtsi > index 5c5acb6..7844d2e 100644 > --- a/arch/powerpc/boot/dts/p1020si.dtsi > +++ b/arch/powerpc/boot/dts/p1020si.dtsi > @@ -190,7 +190,10 @@ > #size-cells = <0>; > compatible = "fsl,etsec2-tbi"; > reg = <0x25000 0x1000 0xb1030 0x4>; > - > + tbi0: tbi-phy@11 { > + reg = <0x11>; > + device_type = "tbi-phy"; > + }; > }; > > enet0: ethernet@b0000 { > @@ -229,6 +232,7 @@ > fsl,num_tx_queues = <0x8>; > local-mac-address = [ 00 00 00 00 00 00 ]; > interrupt-parent = <&mpic>; > + tbi-handle = <&tbi0>; > > queue-group@0 { > #address-cells = <1>; > diff --git a/arch/powerpc/boot/dts/p2020rdb.dts b/arch/powerpc/boot/dts/p2020rdb.dts > index 1d7a05f..2941cbb 100644 > --- a/arch/powerpc/boot/dts/p2020rdb.dts > +++ b/arch/powerpc/boot/dts/p2020rdb.dts > @@ -213,13 +213,6 @@ > }; > }; > > - mdio@25520 { > - tbi0: tbi-phy@11 { > - reg = <0x11>; > - device_type = "tbi-phy"; > - }; > - }; > - > mdio@26520 { > status = "disabled"; > }; > @@ -243,7 +236,6 @@ > }; > > enet1: ethernet@25000 { > - tbi-handle = <&tbi0>; > phy-handle = <&phy0>; > phy-connection-type = "sgmii"; > }; > diff --git a/arch/powerpc/boot/dts/p2020rdb_camp_core0.dts b/arch/powerpc/boot/dts/p2020rdb_camp_core0.dts > index fc8dddd..4641f3d 100644 > --- a/arch/powerpc/boot/dts/p2020rdb_camp_core0.dts > +++ b/arch/powerpc/boot/dts/p2020rdb_camp_core0.dts > @@ -124,13 +124,6 @@ > }; > }; > > - mdio@25520 { > - tbi0: tbi-phy@11 { > - reg = <0x11>; > - device_type = "tbi-phy"; > - }; > - }; > - > mdio@26520 { > status = "disabled"; > }; > @@ -140,7 +133,6 @@ > }; > > enet1: ethernet@25000 { > - tbi-handle = <&tbi0>; > phy-handle = <&phy0>; > phy-connection-type = "sgmii"; > > diff --git a/arch/powerpc/boot/dts/p2020si.dtsi b/arch/powerpc/boot/dts/p2020si.dtsi > index 6def17f..9317075 100644 > --- a/arch/powerpc/boot/dts/p2020si.dtsi > +++ b/arch/powerpc/boot/dts/p2020si.dtsi > @@ -235,6 +235,10 @@ > #size-cells = <0>; > compatible = "fsl,gianfar-tbi"; > reg = <0x26520 0x20>; > + tbi0: tbi-phy@11 { > + reg = <0x11>; > + device_type = "tbi-phy"; > + }; > }; > > mdio@26520 { > @@ -270,7 +274,7 @@ > local-mac-address = [ 00 00 00 00 00 00 ]; > interrupts = <35 2 36 2 40 2>; > interrupt-parent = <&mpic>; > - > + tbi-handle = <&tbi0>; > }; > > enet2: ethernet@26000 { > -- > 1.7.3 > > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org > https://lists.ozlabs.org/listinfo/linuxppc-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB [not found] ` <1307501379-3160-1-git-send-email-prabhakar-KZfg59tc24xl57MIdRCFDg@public.gmane.org> 2011-06-08 14:57 ` Grant Likely @ 2011-06-22 11:34 ` Kumar Gala 2011-06-22 16:34 ` Grant Likely 2011-06-23 7:24 ` Aggrwal Poonam-B10812 1 sibling, 2 replies; 6+ messages in thread From: Kumar Gala @ 2011-06-22 11:34 UTC (permalink / raw) To: Prabhakar Kushwaha Cc: meet2prabhu-Re5JQEeQqe8AvxtiuMwx3w, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ On Jun 7, 2011, at 9:49 PM, Prabhakar Kushwaha wrote: > ten-bit interface (TBI) module is part of SoC not board. > > Move tbi entries from board related dts files to Si dts. > > Signed-off-by: Prabhakar Kushwaha <prabhakar-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > --- > Based upon http://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git (branch next) > > arch/powerpc/boot/dts/p1020rdb.dts | 9 --------- > arch/powerpc/boot/dts/p1020rdb_camp_core0.dts | 8 -------- > arch/powerpc/boot/dts/p1020si.dtsi | 6 +++++- > arch/powerpc/boot/dts/p2020rdb.dts | 8 -------- > arch/powerpc/boot/dts/p2020rdb_camp_core0.dts | 8 -------- > arch/powerpc/boot/dts/p2020si.dtsi | 6 +++++- > 6 files changed, 10 insertions(+), 35 deletions(-) > > diff --git a/arch/powerpc/boot/dts/p1020rdb.dts b/arch/powerpc/boot/dts/p1020rdb.dts > index d6a8ae4..a4e5d6c 100644 > --- a/arch/powerpc/boot/dts/p1020rdb.dts > +++ b/arch/powerpc/boot/dts/p1020rdb.dts > @@ -211,14 +211,6 @@ > }; > }; > > - mdio@25000 { > - > - tbi0: tbi-phy@11 { > - reg = <0x11>; > - device_type = "tbi-phy"; > - }; > - }; > - > enet0: ethernet@b0000 { > fixed-link = <1 1 1000 0 0>; > phy-connection-type = "rgmii-id"; > @@ -227,7 +219,6 @@ > > enet1: ethernet@b1000 { > phy-handle = <&phy0>; > - tbi-handle = <&tbi0>; > phy-connection-type = "sgmii"; > > }; I'm not sure we should do this. The phy address we pick is board specific so it should NOT be in .dtsi - k ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB 2011-06-22 11:34 ` Kumar Gala @ 2011-06-22 16:34 ` Grant Likely 2011-06-23 7:24 ` Aggrwal Poonam-B10812 1 sibling, 0 replies; 6+ messages in thread From: Grant Likely @ 2011-06-22 16:34 UTC (permalink / raw) To: Kumar Gala Cc: meet2prabhu, devicetree-discuss, linuxppc-dev, Prabhakar Kushwaha On Wed, Jun 22, 2011 at 5:34 AM, Kumar Gala <galak@kernel.crashing.org> wrote: > > On Jun 7, 2011, at 9:49 PM, Prabhakar Kushwaha wrote: > >> ten-bit interface (TBI) module is part of SoC not board. >> >> Move tbi entries from board related dts files to Si dts. >> >> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> >> --- >> Based upon http://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git (branch next) >> >> arch/powerpc/boot/dts/p1020rdb.dts | 9 --------- >> arch/powerpc/boot/dts/p1020rdb_camp_core0.dts | 8 -------- >> arch/powerpc/boot/dts/p1020si.dtsi | 6 +++++- >> arch/powerpc/boot/dts/p2020rdb.dts | 8 -------- >> arch/powerpc/boot/dts/p2020rdb_camp_core0.dts | 8 -------- >> arch/powerpc/boot/dts/p2020si.dtsi | 6 +++++- >> 6 files changed, 10 insertions(+), 35 deletions(-) >> >> diff --git a/arch/powerpc/boot/dts/p1020rdb.dts b/arch/powerpc/boot/dts/p1020rdb.dts >> index d6a8ae4..a4e5d6c 100644 >> --- a/arch/powerpc/boot/dts/p1020rdb.dts >> +++ b/arch/powerpc/boot/dts/p1020rdb.dts >> @@ -211,14 +211,6 @@ >> }; >> }; >> >> - mdio@25000 { >> - >> - tbi0: tbi-phy@11 { >> - reg = <0x11>; >> - device_type = "tbi-phy"; >> - }; >> - }; >> - >> enet0: ethernet@b0000 { >> fixed-link = <1 1 1000 0 0>; >> phy-connection-type = "rgmii-id"; >> @@ -227,7 +219,6 @@ >> >> enet1: ethernet@b1000 { >> phy-handle = <&phy0>; >> - tbi-handle = <&tbi0>; >> phy-connection-type = "sgmii"; >> >> }; > > I'm not sure we should do this. The phy address we pick is board specific so it should NOT be in .dtsi Ah, okay. I was under the impression that the tbi address was internal to the SoC, and not configurable. g. ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB 2011-06-22 11:34 ` Kumar Gala 2011-06-22 16:34 ` Grant Likely @ 2011-06-23 7:24 ` Aggrwal Poonam-B10812 [not found] ` <45903308677306428B6EE7E6FF5A52041419B6-TcFNo7jSaXM0vywKSws3iq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org> 1 sibling, 1 reply; 6+ messages in thread From: Aggrwal Poonam-B10812 @ 2011-06-23 7:24 UTC (permalink / raw) To: Kumar Gala, Kushwaha Prabhakar-B32579 Cc: meet2prabhu@gmail.com, devicetree-discuss@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org > -----Original Message----- > From: linuxppc-dev-bounces+poonam.aggrwal=freescale.com@lists.ozlabs.org > [mailto:linuxppc-dev- > bounces+poonam.aggrwal=freescale.com@lists.ozlabs.org] On Behalf Of Kumar > Gala > Sent: Wednesday, June 22, 2011 5:04 PM > To: Kushwaha Prabhakar-B32579 > Cc: meet2prabhu@gmail.com; devicetree-discuss@lists.ozlabs.org; linuxppc- > dev@lists.ozlabs.org > Subject: Re: [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB > > > On Jun 7, 2011, at 9:49 PM, Prabhakar Kushwaha wrote: > > > ten-bit interface (TBI) module is part of SoC not board. > > > > Move tbi entries from board related dts files to Si dts. > > > > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> > > --- > > Based upon > http://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git (branch > next) > > > > arch/powerpc/boot/dts/p1020rdb.dts | 9 --------- > > arch/powerpc/boot/dts/p1020rdb_camp_core0.dts | 8 -------- > > arch/powerpc/boot/dts/p1020si.dtsi | 6 +++++- > > arch/powerpc/boot/dts/p2020rdb.dts | 8 -------- > > arch/powerpc/boot/dts/p2020rdb_camp_core0.dts | 8 -------- > > arch/powerpc/boot/dts/p2020si.dtsi | 6 +++++- > > 6 files changed, 10 insertions(+), 35 deletions(-) > > > > diff --git a/arch/powerpc/boot/dts/p1020rdb.dts > b/arch/powerpc/boot/dts/p1020rdb.dts > > index d6a8ae4..a4e5d6c 100644 > > --- a/arch/powerpc/boot/dts/p1020rdb.dts > > +++ b/arch/powerpc/boot/dts/p1020rdb.dts > > @@ -211,14 +211,6 @@ > > }; > > }; > > > > - mdio@25000 { > > - > > - tbi0: tbi-phy@11 { > > - reg = <0x11>; > > - device_type = "tbi-phy"; > > - }; > > - }; > > - > > enet0: ethernet@b0000 { > > fixed-link = <1 1 1000 0 0>; > > phy-connection-type = "rgmii-id"; > > @@ -227,7 +219,6 @@ > > > > enet1: ethernet@b1000 { > > phy-handle = <&phy0>; > > - tbi-handle = <&tbi0>; > > phy-connection-type = "sgmii"; > > > > }; > > I'm not sure we should do this. The phy address we pick is board > specific so it should NOT be in .dtsi The TBI phy and it's address is internal to SOC. Regards Poonam > > - k > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <45903308677306428B6EE7E6FF5A52041419B6-TcFNo7jSaXM0vywKSws3iq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>]
* Re: [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB [not found] ` <45903308677306428B6EE7E6FF5A52041419B6-TcFNo7jSaXM0vywKSws3iq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org> @ 2011-06-23 10:27 ` Kumar Gala 0 siblings, 0 replies; 6+ messages in thread From: Kumar Gala @ 2011-06-23 10:27 UTC (permalink / raw) To: Aggrwal Poonam-B10812 Cc: meet2prabhu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org On Jun 23, 2011, at 2:24 AM, Aggrwal Poonam-B10812 wrote: > > >> -----Original Message----- >> From: linuxppc-dev-bounces+poonam.aggrwal=freescale.com-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org >> [mailto:linuxppc-dev- >> bounces+poonam.aggrwal=freescale.com-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org] On Behalf Of Kumar >> Gala >> Sent: Wednesday, June 22, 2011 5:04 PM >> To: Kushwaha Prabhakar-B32579 >> Cc: meet2prabhu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; linuxppc- >> dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org >> Subject: Re: [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB >> >> >> On Jun 7, 2011, at 9:49 PM, Prabhakar Kushwaha wrote: >> >>> ten-bit interface (TBI) module is part of SoC not board. >>> >>> Move tbi entries from board related dts files to Si dts. >>> >>> Signed-off-by: Prabhakar Kushwaha <prabhakar-KZfg59tc24xl57MIdRCFDg@public.gmane.org> >>> --- >>> Based upon >> http://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git (branch >> next) >>> >>> arch/powerpc/boot/dts/p1020rdb.dts | 9 --------- >>> arch/powerpc/boot/dts/p1020rdb_camp_core0.dts | 8 -------- >>> arch/powerpc/boot/dts/p1020si.dtsi | 6 +++++- >>> arch/powerpc/boot/dts/p2020rdb.dts | 8 -------- >>> arch/powerpc/boot/dts/p2020rdb_camp_core0.dts | 8 -------- >>> arch/powerpc/boot/dts/p2020si.dtsi | 6 +++++- >>> 6 files changed, 10 insertions(+), 35 deletions(-) >>> >>> diff --git a/arch/powerpc/boot/dts/p1020rdb.dts >> b/arch/powerpc/boot/dts/p1020rdb.dts >>> index d6a8ae4..a4e5d6c 100644 >>> --- a/arch/powerpc/boot/dts/p1020rdb.dts >>> +++ b/arch/powerpc/boot/dts/p1020rdb.dts >>> @@ -211,14 +211,6 @@ >>> }; >>> }; >>> >>> - mdio@25000 { >>> - >>> - tbi0: tbi-phy@11 { >>> - reg = <0x11>; >>> - device_type = "tbi-phy"; >>> - }; >>> - }; >>> - >>> enet0: ethernet@b0000 { >>> fixed-link = <1 1 1000 0 0>; >>> phy-connection-type = "rgmii-id"; >>> @@ -227,7 +219,6 @@ >>> >>> enet1: ethernet@b1000 { >>> phy-handle = <&phy0>; >>> - tbi-handle = <&tbi0>; >>> phy-connection-type = "sgmii"; >>> >>> }; >> >> I'm not sure we should do this. The phy address we pick is board >> specific so it should NOT be in .dtsi > The TBI phy and it's address is internal to SOC. But it is configured to NOT conflict with external PHY addresses. This the setting is board specific in my opinion. - k ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-23 10:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-08 2:49 [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB Prabhakar Kushwaha
[not found] ` <1307501379-3160-1-git-send-email-prabhakar-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-06-08 14:57 ` Grant Likely
2011-06-22 11:34 ` Kumar Gala
2011-06-22 16:34 ` Grant Likely
2011-06-23 7:24 ` Aggrwal Poonam-B10812
[not found] ` <45903308677306428B6EE7E6FF5A52041419B6-TcFNo7jSaXM0vywKSws3iq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2011-06-23 10:27 ` Kumar Gala
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).