From: Jamie Iles <jamie@jamieiles.com>
To: linux-serial@vger.kernel.org, devicetree-discuss@lists.ozlabs.org
Cc: Jamie Iles <jamie@jamieiles.com>, Alan Cox <alan@linux.intel.com>,
Grant Likely <grant.likely@secretlab.ca>
Subject: [PATCH 2/2] tty: of_serial: support for 32 bit accesses
Date: Wed, 15 Jun 2011 13:49:59 +0100 [thread overview]
Message-ID: <1308142199-17972-2-git-send-email-jamie@jamieiles.com> (raw)
In-Reply-To: <1308142199-17972-1-git-send-email-jamie@jamieiles.com>
Some platforms e.g. TI Davinci require 32-bit accesses to the UARTs.
The of_serial driver currently registers all UARTs as UPIO_MEM. Add a
new attribute "io-width" to allow the port to be registered with
different IO width requirements.
Cc: Alan Cox <alan@linux.intel.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
.../devicetree/bindings/tty/serial/of-serial.txt | 3 +++
drivers/tty/serial/of_serial.c | 17 +++++++++++++++++
2 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/Documentation/devicetree/bindings/tty/serial/of-serial.txt b/Documentation/devicetree/bindings/tty/serial/of-serial.txt
index b0c52c2..1771cda 100644
--- a/Documentation/devicetree/bindings/tty/serial/of-serial.txt
+++ b/Documentation/devicetree/bindings/tty/serial/of-serial.txt
@@ -21,6 +21,9 @@ Optional properties:
- reg-shift : quantity to shift the register offsets by.
- used-by-rtas : set to indicate that the port is in use by the firmware and
should not be registered.
+- io-width : the size (in bytes) of the IO accesses that should be performed
+ on the device. There are some systems that require 32-bit accesses to the
+ UART (e.g. TI davinci).
Example:
diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
index 4675243..50810a0 100644
--- a/drivers/tty/serial/of_serial.c
+++ b/drivers/tty/serial/of_serial.c
@@ -65,6 +65,23 @@ static int __devinit of_platform_serial_setup(struct platform_device *ofdev,
port->irq = irq_of_parse_and_map(np, 0);
port->iotype = UPIO_MEM;
+ prop = of_get_property(np, "io-width", &prop_size);
+ if (prop && (prop_size == sizeof(u32))) {
+ switch (be32_to_cpup(prop)) {
+ case 1:
+ port->iotype = UPIO_MEM;
+ break;
+ case 4:
+ port->iotype = UPIO_MEM32;
+ break;
+ default:
+ dev_warn(&ofdev->dev,
+ "unsupported io width (%d bytes)\n",
+ be32_to_cpup(prop));
+ return -EINVAL;
+ }
+ }
+
port->type = type;
port->uartclk = be32_to_cpup(clk);
port->flags = UPF_SHARE_IRQ | UPF_BOOT_AUTOCONF | UPF_IOREMAP
--
1.7.4.1
next prev parent reply other threads:[~2011-06-15 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 12:49 [PATCH 1/2] dt: document the of_serial bindings Jamie Iles
2011-06-15 12:49 ` Jamie Iles [this message]
2011-06-15 12:54 ` [PATCH 2/2] tty: of_serial: support for 32 bit accesses Alan Cox
2011-06-15 13:27 ` Grant Likely
2011-06-15 14:49 ` Jamie Iles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308142199-17972-2-git-send-email-jamie@jamieiles.com \
--to=jamie@jamieiles.com \
--cc=alan@linux.intel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox