* [PATCH] ARM: tegra: gpio: Use engineering names in DT compatible property
@ 2011-07-05 20:15 Stephen Warren
[not found] ` <1309896918-22496-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Warren @ 2011-07-05 20:15 UTC (permalink / raw)
To: Grant Likely, Colin Cross, Olof Johansson, Erik Gilling
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, Stephen Warren
Engineering names are more stable than marketing names. Hence, use them
for Device Tree compatible properties instead.
Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
Grant, This patch is physically against devicetree/arm, but also makes
sense to apply to devicetree/test. This patch will cause conflicts
somewhere, given you previously posted a patch to move gpio.c into
drivers/gpio.
.../devicetree/bindings/gpio/gpio_nvidia.txt | 2 +-
arch/arm/mach-tegra/gpio.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpio/gpio_nvidia.txt b/Documentation/devicetree/bindings/gpio/gpio_nvidia.txt
index afb3ff3..64aac39 100644
--- a/Documentation/devicetree/bindings/gpio/gpio_nvidia.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio_nvidia.txt
@@ -1,7 +1,7 @@
NVIDIA Tegra 2 GPIO controller
Required properties:
-- compatible : "nvidia,tegra250-gpio"
+- compatible : "nvidia,tegra20-gpio"
- #gpio-cells : Should be two. The first cell is the pin number and the
second cell is used to specify optional parameters (currently unused).
- gpio-controller : Marks the device node as a GPIO controller.
diff --git a/arch/arm/mach-tegra/gpio.c b/arch/arm/mach-tegra/gpio.c
index 13afb88..747eb40 100644
--- a/arch/arm/mach-tegra/gpio.c
+++ b/arch/arm/mach-tegra/gpio.c
@@ -347,7 +347,7 @@ static int __init tegra_gpio_init(void)
* driver is converted into a platform_device
*/
tegra_gpio_chip.of_node = of_find_compatible_node(NULL, NULL,
- "nvidia,tegra250-gpio");
+ "nvidia,tegra20-gpio");
#endif /* CONFIG_OF_GPIO */
gpiochip_add(&tegra_gpio_chip);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: tegra: gpio: Use engineering names in DT compatible property
[not found] ` <1309896918-22496-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
@ 2011-07-06 5:37 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2011-07-06 5:37 UTC (permalink / raw)
To: Stephen Warren
Cc: Colin Cross, Olof Johansson, Erik Gilling,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
On Tue, Jul 05, 2011 at 02:15:18PM -0600, Stephen Warren wrote:
> Engineering names are more stable than marketing names. Hence, use them
> for Device Tree compatible properties instead.
>
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Grant, This patch is physically against devicetree/arm, but also makes
> sense to apply to devicetree/test. This patch will cause conflicts
> somewhere, given you previously posted a patch to move gpio.c into
> drivers/gpio.
Applied to gpio/next, Thanks!
g.
>
> .../devicetree/bindings/gpio/gpio_nvidia.txt | 2 +-
> arch/arm/mach-tegra/gpio.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio_nvidia.txt b/Documentation/devicetree/bindings/gpio/gpio_nvidia.txt
> index afb3ff3..64aac39 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio_nvidia.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio_nvidia.txt
> @@ -1,7 +1,7 @@
> NVIDIA Tegra 2 GPIO controller
>
> Required properties:
> -- compatible : "nvidia,tegra250-gpio"
> +- compatible : "nvidia,tegra20-gpio"
> - #gpio-cells : Should be two. The first cell is the pin number and the
> second cell is used to specify optional parameters (currently unused).
> - gpio-controller : Marks the device node as a GPIO controller.
> diff --git a/arch/arm/mach-tegra/gpio.c b/arch/arm/mach-tegra/gpio.c
> index 13afb88..747eb40 100644
> --- a/arch/arm/mach-tegra/gpio.c
> +++ b/arch/arm/mach-tegra/gpio.c
> @@ -347,7 +347,7 @@ static int __init tegra_gpio_init(void)
> * driver is converted into a platform_device
> */
> tegra_gpio_chip.of_node = of_find_compatible_node(NULL, NULL,
> - "nvidia,tegra250-gpio");
> + "nvidia,tegra20-gpio");
> #endif /* CONFIG_OF_GPIO */
>
> gpiochip_add(&tegra_gpio_chip);
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-06 5:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-05 20:15 [PATCH] ARM: tegra: gpio: Use engineering names in DT compatible property Stephen Warren
[not found] ` <1309896918-22496-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-07-06 5:37 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).