From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCHv4] mtd: gpio-nand: add device tree bindings Date: Mon, 15 Aug 2011 17:28:57 +0300 Message-ID: <1313418543.2600.2.camel@sauron> References: <1312902747-21372-1-git-send-email-jamie@jamieiles.com> Reply-To: dedekind1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1312902747-21372-1-git-send-email-jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Jamie Iles Cc: Scott Wood , David Woodhouse , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, 2011-08-09 at 16:12 +0100, Jamie Iles wrote: > - res1 = platform_get_resource(dev, IORESOURCE_MEM, 1); > + if (!dev->dev.of_node) > + res1 = platform_get_resource(dev, IORESOURCE_MEM, 1); > + else > + res1 = gpio_nand_of_get_io_sync(&dev->dev); > + > if (res1) { > gpiomtd->io_sync = request_and_remap(res1, 4, "NAND sync", &ret); > if (!gpiomtd->io_sync) { > @@ -257,7 +362,16 @@ static int __devinit gpio_nand_probe(struct platform_device *dev) > } > } > > - memcpy(&gpiomtd->plat, dev->dev.platform_data, sizeof(gpiomtd->plat)); > + if (dev->dev.of_node) > + kfree(res1); > + > + if (dev->dev.platform_data) > + memcpy(&gpiomtd->plat, dev->dev.platform_data, > + sizeof(gpiomtd->plat)); > + else > + ret = gpio_nand_of_get_config(&dev->dev, &gpiomtd->plat); > + if (ret) > + goto err_nce; > So with this code you can mix platform data and DT? Say, io_sync may come from platform data and the rest from the DT? Is this normal practice? -- Best Regards, Artem Bityutskiy