From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Brian Masney <bmasney@redhat.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFT PATCH 05/14] arm64: dts: qcom: sc8280xp: correct TLMM gpio-ranges
Date: Fri, 3 Feb 2023 01:05:35 +0100 [thread overview]
Message-ID: <1319a973-26ae-8c11-d967-8720aaf894df@linaro.org> (raw)
In-Reply-To: <Y9xOeZjAQmQqLOa1@x1>
On 3.02.2023 00:59, Brian Masney wrote:
> On Fri, Feb 03, 2023 at 12:45:49AM +0100, Konrad Dybcio wrote:
>> On 2.02.2023 23:58, Brian Masney wrote:
>>> On Wed, Feb 01, 2023 at 04:50:56PM +0100, Krzysztof Kozlowski wrote:
>>>> Correct the number of GPIOs in TLMM pin controller.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>>>> index fa2d0d7d1367..17e8c26a9ae6 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>>>> @@ -3533,7 +3533,7 @@ tlmm: pinctrl@f100000 {
>>>> #gpio-cells = <2>;
>>>> interrupt-controller;
>>>> #interrupt-cells = <2>;
>>>> - gpio-ranges = <&tlmm 0 0 230>;
>>>> + gpio-ranges = <&tlmm 0 0 228>;
>> Won't that kill the UFS pins?
>
> For others quick reference, Konrad is talking about this line from
> sa8540p-ride.dts:
>
> reset-gpios = <&tlmm 228 GPIO_ACTIVE_LOW>;
>
> I noticed that earlier but assumed this was one based. However, looking
> at pinctrl-sc8280xp.c I see gpio0..gpio227 defined.
+ gpio229 is the reset pin for the UFS card slot
Konrad
>
> Brian
>
next prev parent reply other threads:[~2023-02-03 0:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 15:50 [RFT PATCH 00/14] ARM/arm64: dts: qcom: correct TLMM gpio-ranges Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 01/14] ARM: dts: qcom: sdx55: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 02/14] ARM: dts: qcom: sdx65: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 03/14] arm64: dts: qcom: msm8953: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 04/14] arm64: dts: qcom: sc7180: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 05/14] arm64: dts: qcom: sc8280xp: " Krzysztof Kozlowski
2023-02-02 22:58 ` Brian Masney
2023-02-02 23:45 ` Konrad Dybcio
2023-02-02 23:59 ` Brian Masney
2023-02-03 0:05 ` Konrad Dybcio [this message]
2023-02-03 0:15 ` Brian Masney
2023-02-03 7:10 ` Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 06/14] arm64: dts: qcom: sdm670: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 07/14] arm64: dts: qcom: sdm845: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 08/14] arm64: dts: qcom: sm6115: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 09/14] arm64: dts: qcom: sm6125: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 10/14] arm64: dts: qcom: sm6350: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 11/14] arm64: dts: qcom: sm6375: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 12/14] arm64: dts: qcom: sm8150: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 13/14] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 14/14] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
2023-02-02 10:39 ` [RFT PATCH 00/14] ARM/arm64: dts: qcom: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319a973-26ae-8c11-d967-8720aaf894df@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).