From: Zhihao Cheng <chengzhihao1@huawei.com>
To: Richard Weinberger <richard@nod.at>,
Daniel Golle <daniel@makrotopia.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Vignesh Raghavendra <vigneshr@ti.com>, robh <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
John Crispin <john@phrozen.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC 2/2] mtd: ubi: add support for protecting critical volumes
Date: Tue, 8 Oct 2024 10:55:32 +0800 [thread overview]
Message-ID: <131bb6bc-1cb3-ead7-12d9-89beba9408ca@huawei.com> (raw)
In-Reply-To: <1249604143.124110.1727726047386.JavaMail.zimbra@nod.at>
在 2024/10/1 3:54, Richard Weinberger 写道:
> ----- Ursprüngliche Mail -----
>> Von: "Daniel Golle" <daniel@makrotopia.org>
>>> like a ubirmvol ... --i-know-what-im-doing.
>>
Sorry for the delay reply, caused by my holiday.
>> True, enforcement doesn't need to happen in kernel (though I think it's
>> nicer, but really just a matter of taste, I guess). ubi-tools would still
>> need to be able to recognize critical volumes somehow, and that could be
>> done by checking if the 'volume-is-critical' property is present in
>> /sys/class/ubi/ubi*_*/of_node/
>
> Exactly.
> I also don't mind adding a in-memory 'volume-is-critical' property to
> UBI directly. I'm just a little hesitated to change the UAPI or the on-disk
> data structures for this features.
Add a new interface under the sysfs is fine.
>
>> If you prefer going down that road instead I will work on patches for
>> git.infradead.org/mtd-utils.git instead.
>
> Yes. When done in userspace, it's also much easier to offer the --i-know-what-im-doing
> flag to still remove a critical volume.
Looks good, I like it.
next prev parent reply other threads:[~2024-10-08 2:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-28 12:47 [PATCH RFC 1/2] dt-bindings: mtd: ubi-volume: add 'volume-is-critical' property Daniel Golle
2024-09-28 12:48 ` [PATCH RFC 2/2] mtd: ubi: add support for protecting critical volumes Daniel Golle
2024-09-29 12:26 ` Richard Weinberger
2024-09-30 1:56 ` Zhihao Cheng
2024-09-30 18:43 ` Richard Weinberger
2024-09-30 19:39 ` Daniel Golle
2024-09-30 19:54 ` Richard Weinberger
2024-10-08 2:55 ` Zhihao Cheng [this message]
2024-09-28 13:02 ` [PATCH RFC 1/2] dt-bindings: mtd: ubi-volume: add 'volume-is-critical' property Krzysztof Kozlowski
2024-09-28 13:09 ` Daniel Golle
2024-09-28 13:45 ` Krzysztof Kozlowski
2024-09-28 14:38 ` Daniel Golle
2024-09-29 4:03 ` Zhihao Cheng
2024-09-29 10:52 ` Daniel Golle
2024-09-29 11:23 ` Zhihao Cheng
2024-09-29 12:16 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=131bb6bc-1cb3-ead7-12d9-89beba9408ca@huawei.com \
--to=chengzhihao1@huawei.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).