From: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: of_irq_init() stopped working in 3.2-rc3
Date: Fri, 25 Nov 2011 18:08:54 +0000 [thread overview]
Message-ID: <1322244534.22757.7.camel@hornet.cambridge.arm.com> (raw)
Hi Rob,
Because your dc9372808412edbc653a675a526c2ee6c0c14a91 "of/irq:
of_irq_find_parent: check for parent equal to child" got reverted in
3.2-rc3, the of_irq_init() doesn't work, as...
8<----------------------------------------------------------
void __init of_irq_init(const struct of_device_id *matches)
{
struct device_node *np, *parent = NULL;
[...]
desc->interrupt_parent = of_irq_find_parent(np);
[...]
/*
* Process all controllers with the current 'parent'.
* First pass will be looking for NULL as the parent.
* The assumption is that NULL parent means a root controller.
*/
list_for_each_entry_safe(desc, temp_desc, &intc_desc_list, list) {
[...]
if (desc->interrupt_parent != parent)
continue;
8<------------------------------------------------------------
... the desc->interrupt_parent is not NULL for the root interrupt controller
any more...
I've temporarily worked the problem around by re-applying the
of_irq_find_parent() change.
Cheers!
Paweł
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
next reply other threads:[~2011-11-25 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 18:08 Pawel Moll [this message]
[not found] ` <1322244534.22757.7.camel-okZbbLrgpR/YkXV2EHHjLW3o5bpOHsLO@public.gmane.org>
2011-11-26 16:05 ` of_irq_init() stopped working in 3.2-rc3 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322244534.22757.7.camel@hornet.cambridge.arm.com \
--to=pawel.moll-5wv7dgnigg8@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).