* [PATCH] of/irq: of_irq_init: add check for parent equal to child node
@ 2011-11-28 2:49 Rob Herring
2011-11-28 10:54 ` Pawel Moll
2011-11-29 0:40 ` Stephen Warren
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2011-11-28 2:49 UTC (permalink / raw)
To: linux-kernel, devicetree-discuss; +Cc: Grant Likely, benh, Rob Herring
From: Rob Herring <rob.herring@calxeda.com>
With the revert of "of/irq: of_irq_find_parent: check for parent equal to
child" (dc9372808412edb), we need another way to handle parent node equal
to the child node. This can simply be handled in of_irq_init by checking
for this condition.
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
drivers/of/irq.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 791270b..19c0115 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -424,6 +424,8 @@ void __init of_irq_init(const struct of_device_id *matches)
desc->dev = np;
desc->interrupt_parent = of_irq_find_parent(np);
+ if (desc->interrupt_parent == np)
+ desc->interrupt_parent = NULL;
list_add_tail(&desc->list, &intc_desc_list);
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] of/irq: of_irq_init: add check for parent equal to child node
2011-11-28 2:49 [PATCH] of/irq: of_irq_init: add check for parent equal to child node Rob Herring
@ 2011-11-28 10:54 ` Pawel Moll
2011-11-29 0:40 ` Stephen Warren
1 sibling, 0 replies; 3+ messages in thread
From: Pawel Moll @ 2011-11-28 10:54 UTC (permalink / raw)
To: Rob Herring; +Cc: linux-kernel, devicetree-discuss, Rob Herring
On Sun, 2011-11-27 at 20:49 -0600, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> With the revert of "of/irq: of_irq_find_parent: check for parent equal to
> child" (dc9372808412edb), we need another way to handle parent node equal
> to the child node. This can simply be handled in of_irq_init by checking
> for this condition.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Works for me, thanks!
Tested-by: Pawel Moll <pawel.moll@arm.com>
Cheers!
Paweł
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] of/irq: of_irq_init: add check for parent equal to child node
2011-11-28 2:49 [PATCH] of/irq: of_irq_init: add check for parent equal to child node Rob Herring
2011-11-28 10:54 ` Pawel Moll
@ 2011-11-29 0:40 ` Stephen Warren
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Warren @ 2011-11-29 0:40 UTC (permalink / raw)
To: Rob Herring, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Cc: Rob Herring
Rob Herring wrote at Sunday, November 27, 2011 7:49 PM:
> From: Rob Herring <rob.herring@calxeda.com>
>
> With the revert of "of/irq: of_irq_find_parent: check for parent equal to
> child" (dc9372808412edb), we need another way to handle parent node equal
> to the child node. This can simply be handled in of_irq_init by checking
> for this condition.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Tested-by: Stephen Warren <swarren@nvidia.com>
This fixed the issue I was having testing a Tegra patch that converted
over to the new ARM GIC bindings.
--
nvpublic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-29 0:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-28 2:49 [PATCH] of/irq: of_irq_init: add check for parent equal to child node Rob Herring
2011-11-28 10:54 ` Pawel Moll
2011-11-29 0:40 ` Stephen Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).