From: Krzysztof Kozlowski <krzk@kernel.org>
To: Erikas Bitovtas <xerikasxx@gmail.com>,
David Lechner <dlechner@baylibre.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Peter Meerwald" <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: light: vcnl4000: add Capella CM36686 and CM36672P
Date: Mon, 16 Feb 2026 08:27:52 +0100 [thread overview]
Message-ID: <1326c41d-e4cf-493e-a758-364edaddd04f@kernel.org> (raw)
In-Reply-To: <eea4cf8c-4126-49a8-ada8-1b1893a406c2@gmail.com>
On 15/02/2026 17:16, Erikas Bitovtas wrote:
>> But CM36686 is fully compatible with CM36672P, right?
>>
>> So this would make sense?
>>
>> - items:
>> - const: capella,cm36686
>> - const: vishay,vcnl4040
>> - const: capella,cm36686p
>>
>>
> If you try to use CM36686 compatible for CM36672P, proximity channels
> will work, but in_illuminance_raw will return 0 and changing illuminance
> parameters will have no effect. That is because CM36672P is a proximity
> sensor only and the register fields for ambient light are reserved.
> And if you try to use CM36672P compatible with CM36686, it will work,
> but only proximity channel will be available, even though CM36686 also
> can sense light.
So clearly CM36672P is the superset and should be used with CM36686
fallback.
Lack of the fallback how the patch is written now is a mistake.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-16 7:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 14:42 [PATCH v4 0/2] iio: light: Add support for Capella cm36686 and cm36672p sensors Erikas Bitovtas
2026-02-12 14:42 ` [PATCH v4 1/2] dt-bindings: iio: light: vcnl4000: add Capella CM36686 and CM36672P Erikas Bitovtas
2026-02-13 7:54 ` Krzysztof Kozlowski
2026-02-13 8:29 ` Erikas Bitovtas
2026-02-13 8:51 ` Krzysztof Kozlowski
2026-02-13 8:56 ` Erikas Bitovtas
2026-02-14 16:44 ` David Lechner
2026-02-15 16:16 ` Erikas Bitovtas
2026-02-15 19:35 ` Jonathan Cameron
2026-02-16 7:27 ` Krzysztof Kozlowski [this message]
2026-02-16 8:49 ` Erikas Bitovtas
2026-02-16 9:03 ` Krzysztof Kozlowski
2026-02-15 17:49 ` Jonathan Cameron
2026-02-15 18:00 ` Erikas Bitovtas
2026-02-15 19:38 ` Jonathan Cameron
2026-02-12 14:42 ` [PATCH v4 2/2] iio: light: vcnl4000: add support for " Erikas Bitovtas
2026-02-12 16:20 ` Andy Shevchenko
2026-02-14 18:09 ` Jonathan Cameron
2026-02-15 17:28 ` Erikas Bitovtas
2026-02-15 19:31 ` Jonathan Cameron
2026-02-15 20:06 ` Erikas Bitovtas
2026-02-15 21:55 ` Jonathan Cameron
2026-02-16 8:21 ` Erikas Bitovtas
2026-02-18 19:32 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326c41d-e4cf-493e-a758-364edaddd04f@kernel.org \
--to=krzk@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=phone-devel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
--cc=xerikasxx@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox