devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: U-Boot Mailing List <u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org>
Cc: Albert ARIBAUD
	<albert.u.boot-LhW3hqR2+23R7s880joybQ@public.gmane.org>,
	Devicetree Discuss
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	Jerry Van Baren
	<vanbaren-He//nVnquyzQT0dZR+AlfA@public.gmane.org>,
	Tom Warren <twarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH v5 02/18] arm: fdt: Ensure that an embedded fdt is word-aligned
Date: Tue, 24 Jan 2012 15:20:56 -0800	[thread overview]
Message-ID: <1327447272-30182-3-git-send-email-sjg@chromium.org> (raw)
In-Reply-To: <1327447272-30182-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

By putting the fdt blob into a distinctive area we can ensure that it appears
at the start of the data section and is word-aligned.

Note: It does not seem to be possible to get objcopy to honour its
--section-alignment flag, which would otherwise provide an easier fix
for this problem.

Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
---

 arch/arm/cpu/armv7/u-boot.lds |    5 +++++
 dts/Makefile                  |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/arch/arm/cpu/armv7/u-boot.lds b/arch/arm/cpu/armv7/u-boot.lds
index 40ecf78..793e51b 100644
--- a/arch/arm/cpu/armv7/u-boot.lds
+++ b/arch/arm/cpu/armv7/u-boot.lds
@@ -43,6 +43,11 @@ SECTIONS
 
 	. = ALIGN(4);
 	.data : {
+		/*
+		 * Sadly objcopy seems to ignore --section-alignment.
+		 * Put any embedded device tree first so it is aligned.
+		 */
+		*(.dts.data)
 		*(.data)
 	}
 
diff --git a/dts/Makefile b/dts/Makefile
index 5792afd..83547d4 100644
--- a/dts/Makefile
+++ b/dts/Makefile
@@ -79,7 +79,7 @@ $(obj)dt.o: $(DT_BIN)
 	\
 	cd $(dir ${DT_BIN}) && \
 	$(OBJCOPY) -I binary -O $${oformat} -B $${oarch} \
-		$(notdir ${DT_BIN}) $@
+		--prefix-sections=.dts $(notdir ${DT_BIN}) $@
 	rm $(DT_BIN)
 
 OBJS-$(CONFIG_OF_EMBED)	:= dt.o
-- 
1.7.7.3

  parent reply	other threads:[~2012-01-24 23:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1327447272-30182-1-git-send-email-sjg@chromium.org>
     [not found] ` <1327447272-30182-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-01-24 23:20   ` [PATCH v5 01/18] fdt: Add basic support for decoding GPIO definitions Simon Glass
2012-01-24 23:20   ` Simon Glass [this message]
2012-01-24 23:20   ` [PATCH v5 03/18] arm: fdt: Add skeleton device tree file from kernel Simon Glass
2012-01-24 23:20   ` [PATCH v5 04/18] tegra: fdt: Add Tegra2x " Simon Glass
2012-01-24 23:20   ` [PATCH v5 05/18] tegra: fdt: Add device tree file for Tegra2 Seaboard " Simon Glass
2012-01-24 23:21   ` [PATCH v5 06/18] fdt: Add staging area for device tree binding documentation Simon Glass
2012-01-24 23:21   ` [PATCH v5 07/18] fdt: Add tegra-usb bindings file from linux Simon Glass
2012-01-24 23:21   ` [PATCH v5 08/18] tegra: fdt: Add additional USB binding Simon Glass
     [not found]     ` <1327447272-30182-9-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-02-02 21:55       ` Stephen Warren
     [not found]         ` <4F2B063B.2020403-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-02-03 16:58           ` Simon Glass
2012-01-24 23:21   ` [PATCH v5 09/18] tegra: fdt: Add clock bindings Simon Glass
2012-01-24 23:21   ` [PATCH v5 10/18] tegra: usb: fdt: Add additional device tree definitions for USB ports Simon Glass
     [not found]     ` <1327447272-30182-11-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-02-02 22:07       ` Stephen Warren
2012-02-03 17:04         ` Simon Glass
2012-01-24 23:21   ` [PATCH v5 11/18] tegra: usb: fdt: Add USB definitions for Tegra2 Seaboard Simon Glass
2012-01-24 23:21   ` [PATCH v5 13/18] fdt: Add function to return peripheral/clock ID Simon Glass
2012-01-24 23:21   ` [PATCH v5 18/18] tegra: fdt: Enable FDT support for Seaboard Simon Glass
     [not found]     ` <1327447272-30182-19-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-02-02 22:17       ` Stephen Warren
2012-02-03 17:05         ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327447272-30182-3-git-send-email-sjg@chromium.org \
    --to=sjg-f7+t8e8rja9g9huczpvpmw@public.gmane.org \
    --cc=albert.u.boot-LhW3hqR2+23R7s880joybQ@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=twarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \
    --cc=vanbaren-He//nVnquyzQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).