[PATCH] scripts: dtc: fix compile warnings

[PATCH] scripts: dtc: fix compile warnings

[Felipe Balbi]

Fix following compile warnings:

scripts/dtc/flattree.c: In function ‘flat_read_mem_reserve’:
scripts/dtc/flattree.c:700:14: warning: variable ‘p’ set but not used
	[-Wunused-but-set-variable]

scripts/dtc/dtc.c: In function ‘main’:
scripts/dtc/dtc.c:104:17: warning: variable ‘check’ set but not used
	[-Wunused-but-set-variable]

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 scripts/dtc/dtc.c      |    5 +----
 scripts/dtc/flattree.c |    2 --
 2 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/scripts/dtc/dtc.c b/scripts/dtc/dtc.c
index 451c92d..2ef5e2e 100644
--- a/scripts/dtc/dtc.c
+++ b/scripts/dtc/dtc.c
@@ -101,7 +101,7 @@ int main(int argc, char *argv[])
 	const char *outform = "dts";
 	const char *outname = "-";
 	const char *depname = NULL;
-	int force = 0, check = 0, sort = 0;
+	int force = 0, sort = 0;
 	const char *arg;
 	int opt;
 	FILE *outf = NULL;
@@ -143,9 +143,6 @@ int main(int argc, char *argv[])
 		case 'f':
 			force = 1;
 			break;
-		case 'c':
-			check = 1;
-			break;
 		case 'q':
 			quiet++;
 			break;
diff --git a/scripts/dtc/flattree.c b/scripts/dtc/flattree.c
index ead0332..28d0b23 100644
--- a/scripts/dtc/flattree.c
+++ b/scripts/dtc/flattree.c
@@ -697,7 +697,6 @@ static struct reserve_info *flat_read_mem_reserve(struct inbuf *inb)
 {
 	struct reserve_info *reservelist = NULL;
 	struct reserve_info *new;
-	const char *p;
 	struct fdt_reserve_entry re;
 
 	/*
@@ -706,7 +705,6 @@ static struct reserve_info *flat_read_mem_reserve(struct inbuf *inb)
 	 *
 	 * First pass, count entries.
 	 */
-	p = inb->ptr;
 	while (1) {
 		flat_read_chunk(inb, &re, sizeof(re));
 		re.address  = fdt64_to_cpu(re.address);
-- 
1.7.8.2

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

RE: [PATCH] scripts: dtc: fix compile warnings

[Stephen Warren]

Felipe Balbi wrote at Thursday, January 26, 2012 4:20 AM:
> Fix following compile warnings:
> 
> scripts/dtc/flattree.c: In function ‘flat_read_mem_reserve’:
> scripts/dtc/flattree.c:700:14: warning: variable ‘p’ set but not used
> 	[-Wunused-but-set-variable]
> 
> scripts/dtc/dtc.c: In function ‘main’:
> scripts/dtc/dtc.c:104:17: warning: variable ‘check’ set but not used
> 	[-Wunused-but-set-variable]
> 
> Signed-off-by: Felipe Balbi <balbi@ti.com>

I think you want to send this to the upstream dtc maintainers; I've CC'd
them on this mail.

> ---
>  scripts/dtc/dtc.c      |    5 +----
>  scripts/dtc/flattree.c |    2 --
>  2 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/scripts/dtc/dtc.c b/scripts/dtc/dtc.c
> index 451c92d..2ef5e2e 100644
> --- a/scripts/dtc/dtc.c
> +++ b/scripts/dtc/dtc.c
> @@ -101,7 +101,7 @@ int main(int argc, char *argv[])
>  	const char *outform = "dts";
>  	const char *outname = "-";
>  	const char *depname = NULL;
> -	int force = 0, check = 0, sort = 0;
> +	int force = 0, sort = 0;
>  	const char *arg;
>  	int opt;
>  	FILE *outf = NULL;
> @@ -143,9 +143,6 @@ int main(int argc, char *argv[])
>  		case 'f':
>  			force = 1;
>  			break;
> -		case 'c':
> -			check = 1;
> -			break;
>  		case 'q':
>  			quiet++;
>  			break;
> diff --git a/scripts/dtc/flattree.c b/scripts/dtc/flattree.c
> index ead0332..28d0b23 100644
> --- a/scripts/dtc/flattree.c
> +++ b/scripts/dtc/flattree.c
> @@ -697,7 +697,6 @@ static struct reserve_info *flat_read_mem_reserve(struct inbuf *inb)
>  {
>  	struct reserve_info *reservelist = NULL;
>  	struct reserve_info *new;
> -	const char *p;
>  	struct fdt_reserve_entry re;
> 
>  	/*
> @@ -706,7 +705,6 @@ static struct reserve_info *flat_read_mem_reserve(struct inbuf *inb)
>  	 *
>  	 * First pass, count entries.
>  	 */
> -	p = inb->ptr;
>  	while (1) {
>  		flat_read_chunk(inb, &re, sizeof(re));
>  		re.address  = fdt64_to_cpu(re.address);
> --
> 1.7.8.2

-- 
nvpublic

Re: [PATCH] scripts: dtc: fix compile warnings

[Jon Loeliger]

> RmVsaXBlIEJhbGJpIHdyb3RlIGF0IFRodXJzZGF5LCBKYW51YXJ5IDI2LCAyMDEyIDQ6MjAgQU06
> DQo+IEZpeCBmb2xsb3dpbmcgY29tcGlsZSB3YXJuaW5nczoNCj4gDQo+IHNjcmlwdHMvZHRjL2Zs
> YXR0cmVlLmM6IEluIGZ1bmN0aW9uIOKAmGZsYXRfcmVhZF9tZW1fcmVzZXJ2ZeKAmToNCj4gc2Ny
> aXB0cy9kdGMvZmxhdHRyZWUuYzo3MDA6MTQ6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmHDigJkgc2V0
> IGJ1dCBub3QgdXNlZA0KPiAJWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdDQo+IA0KPiBzY3Jp
> cHRzL2R0Yy9kdGMuYzogSW4gZnVuY3Rpb24g4oCYbWFpbuKAmToNCj4gc2NyaXB0cy9kdGMvZHRj
> LmM6MTA0OjE3OiB3YXJuaW5nOiB2YXJpYWJsZSDigJhjaGVja+KAmSBzZXQgYnV0IG5vdCB1c2Vk
> DQo+IAlbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEZl
> bGlwZSBCYWxiaSA8YmFsYmlAdGkuY29tPg0KDQpJIHRoaW5rIHlvdSB3YW50IHRvIHNlbmQgdGhp
> cyB0byB0aGUgdXBzdHJlYW0gZHRjIG1haW50YWluZXJzOyBJJ3ZlIENDJ2QNCnRoZW0gb24gdGhp
> cyBtYWlsLg0KDQo+IC0tLQ0KPiAgc2NyaXB0cy9kdGMvZHRjLmMgICAgICB8ICAgIDUgKy0tLS0N
> Cj4gIHNjcmlwdHMvZHRjL2ZsYXR0cmVlLmMgfCAgICAyIC0tDQo+ICAyIGZpbGVzIGNoYW5nZWQs
> IDEgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9zY3Jp
> cHRzL2R0Yy9kdGMuYyBiL3NjcmlwdHMvZHRjL2R0Yy5jDQo+IGluZGV4IDQ1MWM5MmQuLjJlZjVl
> MmUgMTAwNjQ0DQo+IC0tLSBhL3NjcmlwdHMvZHRjL2R0Yy5jDQo+ICsrKyBiL3NjcmlwdHMvZHRj
> L2R0Yy5jDQo+IEBAIC0xMDEsNyArMTAxLDcgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFy
> Z3ZbXSkNCj4gIAljb25zdCBjaGFyICpvdXRmb3JtID0gImR0cyI7DQo+ICAJY29uc3QgY2hhciAq
> b3V0bmFtZSA9ICItIjsNCj4gIAljb25zdCBjaGFyICpkZXBuYW1lID0gTlVMTDsNCj4gLQlpbnQg
> Zm9yY2UgPSAwLCBjaGVjayA9IDAsIHNvcnQgPSAwOw0KPiArCWludCBmb3JjZSA9IDAsIHNvcnQg
> PSAwOw0KPiAgCWNvbnN0IGNoYXIgKmFyZzsNCj4gIAlpbnQgb3B0Ow0KPiAgCUZJTEUgKm91dGYg
> PSBOVUxMOw0KPiBAQCAtMTQzLDkgKzE0Myw2IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICph
> cmd2W10pDQo+ICAJCWNhc2UgJ2YnOg0KPiAgCQkJZm9yY2UgPSAxOw0KPiAgCQkJYnJlYWs7DQo+
> IC0JCWNhc2UgJ2MnOg0KPiAtCQkJY2hlY2sgPSAxOw0KPiAtCQkJYnJlYWs7DQo+ICAJCWNhc2Ug
> J3EnOg0KPiAgCQkJcXVpZXQrKzsNCj4gIAkJCWJyZWFrOw0KPiBkaWZmIC0tZ2l0IGEvc2NyaXB0
> cy9kdGMvZmxhdHRyZWUuYyBiL3NjcmlwdHMvZHRjL2ZsYXR0cmVlLmMNCj4gaW5kZXggZWFkMDMz
> Mi4uMjhkMGIyMyAxMDA2NDQNCj4gLS0tIGEvc2NyaXB0cy9kdGMvZmxhdHRyZWUuYw0KPiArKysg
> Yi9zY3JpcHRzL2R0Yy9mbGF0dHJlZS5jDQo+IEBAIC02OTcsNyArNjk3LDYgQEAgc3RhdGljIHN0
> cnVjdCByZXNlcnZlX2luZm8gKmZsYXRfcmVhZF9tZW1fcmVzZXJ2ZShzdHJ1Y3QgaW5idWYgKmlu
> YikNCj4gIHsNCj4gIAlzdHJ1Y3QgcmVzZXJ2ZV9pbmZvICpyZXNlcnZlbGlzdCA9IE5VTEw7DQo+
> ICAJc3RydWN0IHJlc2VydmVfaW5mbyAqbmV3Ow0KPiAtCWNvbnN0IGNoYXIgKnA7DQo+ICAJc3Ry
> dWN0IGZkdF9yZXNlcnZlX2VudHJ5IHJlOw0KPiANCj4gIAkvKg0KPiBAQCAtNzA2LDcgKzcwNSw2
> IEBAIHN0YXRpYyBzdHJ1Y3QgcmVzZXJ2ZV9pbmZvICpmbGF0X3JlYWRfbWVtX3Jlc2VydmUoc3Ry
> dWN0IGluYnVmICppbmIpDQo+ICAJICoNCj4gIAkgKiBGaXJzdCBwYXNzLCBjb3VudCBlbnRyaWVz
> Lg0KPiAgCSAqLw0KPiAtCXAgPSBpbmItPnB0cjsNCj4gIAl3aGlsZSAoMSkgew0KPiAgCQlmbGF0
> X3JlYWRfY2h1bmsoaW5iLCAmcmUsIHNpemVvZihyZSkpOw0KPiAgCQlyZS5hZGRyZXNzICA9IGZk
> dDY0X3RvX2NwdShyZS5hZGRyZXNzKTsNCj4gLS0NCj4gMS43LjguMg0KDQotLSANCm52cHVibGlj
> DQoNCg==

Yeah, that issue has been fixed in the main DTC repo already.

jdl


PS -- No point.  Nope.

Re: [PATCH] scripts: dtc: fix compile warnings

[Michal Marek]

On Thu, Jan 26, 2012 at 01:20:07PM +0200, Felipe Balbi wrote:
> Fix following compile warnings:
> 
> scripts/dtc/flattree.c: In function ‘flat_read_mem_reserve’:
> scripts/dtc/flattree.c:700:14: warning: variable ‘p’ set but not used
> 	[-Wunused-but-set-variable]
> 
> scripts/dtc/dtc.c: In function ‘main’:
> scripts/dtc/dtc.c:104:17: warning: variable ‘check’ set but not used
> 	[-Wunused-but-set-variable]
> 
> Signed-off-by: Felipe Balbi <balbi@ti.com>

This was somehow forgotten, I applied the patch to kbuild.git#kbuild now.

> ---
>  scripts/dtc/dtc.c      |    5 +----
>  scripts/dtc/flattree.c |    2 --
>  2 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/scripts/dtc/dtc.c b/scripts/dtc/dtc.c
> index 451c92d..2ef5e2e 100644
> --- a/scripts/dtc/dtc.c
> +++ b/scripts/dtc/dtc.c
> @@ -101,7 +101,7 @@ int main(int argc, char *argv[])
>  	const char *outform = "dts";
>  	const char *outname = "-";
>  	const char *depname = NULL;
> -	int force = 0, check = 0, sort = 0;
> +	int force = 0, sort = 0;
>  	const char *arg;
>  	int opt;
>  	FILE *outf = NULL;
> @@ -143,9 +143,6 @@ int main(int argc, char *argv[])
>  		case 'f':
>  			force = 1;
>  			break;
> -		case 'c':
> -			check = 1;
> -			break;

BTW, you should also remove 'c' from the getopt() string.

Michal
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] scripts: dtc: fix compile warnings

[Grant Likely]

[-- Attachment #1: Type: text/plain, Size: 2349 bytes --]

On Thu, 26 Jan 2012 13:20:07 +0200, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> wrote:
> Fix following compile warnings:
> 
> scripts/dtc/flattree.c: In function ‘flat_read_mem_reserve’:
> scripts/dtc/flattree.c:700:14: warning: variable ‘p’ set but not used
> 	[-Wunused-but-set-variable]
> 
> scripts/dtc/dtc.c: In function ‘main’:
> scripts/dtc/dtc.c:104:17: warning: variable ‘check’ set but not used
> 	[-Wunused-but-set-variable]
> 
> Signed-off-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>

Need to instead update dtc to the latest sources from the upstream dtc
repository.  I've not had time to do it; would you like to take a
look?

g.

> ---
>  scripts/dtc/dtc.c      |    5 +----
>  scripts/dtc/flattree.c |    2 --
>  2 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/scripts/dtc/dtc.c b/scripts/dtc/dtc.c
> index 451c92d..2ef5e2e 100644
> --- a/scripts/dtc/dtc.c
> +++ b/scripts/dtc/dtc.c
> @@ -101,7 +101,7 @@ int main(int argc, char *argv[])
>  	const char *outform = "dts";
>  	const char *outname = "-";
>  	const char *depname = NULL;
> -	int force = 0, check = 0, sort = 0;
> +	int force = 0, sort = 0;
>  	const char *arg;
>  	int opt;
>  	FILE *outf = NULL;
> @@ -143,9 +143,6 @@ int main(int argc, char *argv[])
>  		case 'f':
>  			force = 1;
>  			break;
> -		case 'c':
> -			check = 1;
> -			break;
>  		case 'q':
>  			quiet++;
>  			break;
> diff --git a/scripts/dtc/flattree.c b/scripts/dtc/flattree.c
> index ead0332..28d0b23 100644
> --- a/scripts/dtc/flattree.c
> +++ b/scripts/dtc/flattree.c
> @@ -697,7 +697,6 @@ static struct reserve_info *flat_read_mem_reserve(struct inbuf *inb)
>  {
>  	struct reserve_info *reservelist = NULL;
>  	struct reserve_info *new;
> -	const char *p;
>  	struct fdt_reserve_entry re;
>  
>  	/*
> @@ -706,7 +705,6 @@ static struct reserve_info *flat_read_mem_reserve(struct inbuf *inb)
>  	 *
>  	 * First pass, count entries.
>  	 */
> -	p = inb->ptr;
>  	while (1) {
>  		flat_read_chunk(inb, &re, sizeof(re));
>  		re.address  = fdt64_to_cpu(re.address);
> -- 
> 1.7.8.2
> 
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss