From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: jdl-CYoMK+44s/E@public.gmane.org
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: [PATCH 09/10] Don't use diff to check fdt{get,put} results
Date: Fri, 3 Feb 2012 16:12:08 +1100 [thread overview]
Message-ID: <1328245929-15443-10-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1328245929-15443-1-git-send-email-david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Currently the fdt{get,put}-runtest.sh scripts invoke diff to check if
fdt{get,put} did the right thing. This isn't great though: it's not
obvious from the diff output which is the expected and which is the
actual result; diff's line by line behaviour is useless here, since all
the results are a single line and finally, when there is a difference
it always prints information even when the tests are supposed to be
running in quiet mode.
This patch uses cmp instead, and explicitly prints the expected results,
when running in verbose mode (the invocation of fdtget itself will have
already displayed the actual results in this mode.
Signed-off-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
---
tests/fdtget-runtest.sh | 13 +++++++------
tests/fdtput-runtest.sh | 13 +++++++------
2 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/tests/fdtget-runtest.sh b/tests/fdtget-runtest.sh
index 75e7503..dac7f9a 100755
--- a/tests/fdtget-runtest.sh
+++ b/tests/fdtget-runtest.sh
@@ -13,11 +13,12 @@ shift
verbose_run_log_check "$LOG" $VALGRIND $DTGET "$@"
-diff $EXPECT $LOG
-ret="$?"
-
-if [ "$ret" -eq 0 ]; then
- PASS
+if cmp $EXPECT $LOG>/dev/null; then
+ PASS
else
- FAIL
+ if [ -z "$QUIET_TEST" ]; then
+ echo "EXPECTED :-:"
+ cat $EXPECT
+ fi
+ FAIL "Results differ from expected"
fi
diff --git a/tests/fdtput-runtest.sh b/tests/fdtput-runtest.sh
index dbd9c0d..527a968 100644
--- a/tests/fdtput-runtest.sh
+++ b/tests/fdtput-runtest.sh
@@ -28,11 +28,12 @@ verbose_run_check $VALGRIND "$DTPUT" "$dtb" "$node" "$property" $value $flags
# Now fdtget to read the value
verbose_run_log_check "$LOG" $VALGRIND "$DTGET" "$dtb" "$node" "$property" $flags
-diff $EXPECT $LOG
-ret="$?"
-
-if [ "$ret" -eq 0 ]; then
- PASS
+if cmp $EXPECT $LOG >/dev/null; then
+ PASS
else
- FAIL
+ if [ -z "$QUIET_TEST" ]; then
+ echo "EXPECTED :-:"
+ cat $EXPECT
+ fi
+ FAIL "Results differ from expected"
fi
--
1.7.8.3
next prev parent reply other threads:[~2012-02-03 5:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 5:11 [0/10] Assorted cleanups (esp for fdt{get,put} tests) David Gibson
[not found] ` <1328245929-15443-1-git-send-email-david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
2012-02-03 5:12 ` [PATCH 01/10] Update .gitignore for tests David Gibson
2012-02-03 5:12 ` [PATCH 02/10] Add quilt files to .gitignore David Gibson
2012-02-03 5:12 ` [PATCH 03/10] Trivial style fixup David Gibson
2012-02-03 5:12 ` [PATCH 04/10] Remove unused variable from test scripts David Gibson
2012-02-03 5:12 ` [PATCH 05/10] Use 'trap' builtin to clean up temporaries in " David Gibson
2012-02-03 5:12 ` [PATCH 06/10] Remove bashism from run_tests.sh David Gibson
2012-02-03 5:12 ` [PATCH 07/10] Factor signal checks out of test scripts David Gibson
2012-02-03 5:12 ` [PATCH 08/10] Clean up invocation of fdt{get,put} tests David Gibson
[not found] ` <1328245929-15443-9-git-send-email-david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
2012-02-03 15:47 ` Simon Glass
2012-02-03 5:12 ` David Gibson [this message]
2012-02-03 5:12 ` [PATCH 10/10] Generate test data for fdtput more sensibly David Gibson
2012-02-03 14:45 ` [0/10] Assorted cleanups (esp for fdt{get,put} tests) Jon Loeliger
2012-02-03 18:22 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328245929-15443-10-git-send-email-david@gibson.dropbear.id.au \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=jdl-CYoMK+44s/E@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).