From: sbhanu@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>
Cc: adrian.hunter@intel.com, mka@chromium.org, robh+dt@kernel.org,
ulf.hansson@linaro.org, asutoshd@codeaurora.org,
stummala@codeaurora.org, sayalil@codeaurora.org,
cang@codeaurora.org, rampraka@codeaurora.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
agross@kernel.org, bjorn.andersson@linaro.org,
devicetree-owner@vger.kernel.org
Subject: Re: [PATCH V2] mmc: sdhci-msm: Update system suspend/resume callbacks of sdhci-msm platform driver.
Date: Tue, 11 Feb 2020 20:08:02 +0530 [thread overview]
Message-ID: <1328455c7256f41f3f3bd9b96fb21d8d@codeaurora.org> (raw)
In-Reply-To: <158136367603.121156.1867941302835915258@swboyd.mtv.corp.google.com>
On 2020-02-11 01:11, Stephen Boyd wrote:
> Quoting Shaik Sajida Bhanu (2020-02-07 05:20:50)
>> The existing suspend/resume callbacks of sdhci-msm driver are just
>> gating/un-gating the clocks. During suspend cycle more can be done
>> like disabling controller, interrupts and card detection.
>>
>> So updating the system pm callbacks for performing these extra
>> actions besides controlling the clocks.
>>
>> Signed-off-by: Shaik Sajida Bhanu <sbhanu@codeaurora.org>
>>
>> Changes since V1:
>> Addressed review comments
>
> Please don't write this. Instead, describe what's actually different so
> the reader doesn't have to go figure out what the review comments were.
>
sure
>> ---
>> drivers/mmc/host/sdhci-msm.c | 50
>> ++++++++++++++++++++++++++++++++++++++++++--
>> 1 file changed, 48 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-msm.c
>> b/drivers/mmc/host/sdhci-msm.c
>> index c3a160c..e30c8a3 100644
>> --- a/drivers/mmc/host/sdhci-msm.c
>> +++ b/drivers/mmc/host/sdhci-msm.c
>> @@ -2159,9 +2159,55 @@ static __maybe_unused int
>> sdhci_msm_runtime_resume(struct device *dev)
>> return 0;
>> }
>>
>> +static int sdhci_msm_suspend(struct device *dev)
>> +{
>> + struct sdhci_host *host = dev_get_drvdata(dev);
>> + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>> + struct sdhci_msm_host *msm_host =
>> sdhci_pltfm_priv(pltfm_host);
>> + int ret;
>> +
>> + if (host->mmc->caps2 & MMC_CAP2_CQE) {
>> + ret = cqhci_suspend(host->mmc);
>> + if (ret)
>> + return ret;
>> + }
>> +
>> + ret = sdhci_suspend_host(host);
>> + if (ret)
>> + return ret;
>> + /* Disable pwr-irq since SDHC would be inactive */
>> + disable_irq(msm_host->pwr_irq);
>
> Why do we need to do this? If it's inactive then the irq won't be
> raised
> by the inactive hardware. Given that we're going to suspend the device,
> the irq won't matter unless it's marked for wakeup. Please remove this
> irq enable/disable logic, or explain why it's really needed.
>
You are right. This is not needed.
We have checked more on this and interrupt are getting disabled in
suspend_device_irqs().
Will remove this.
>> +
>> + return pm_runtime_force_suspend(dev);
>> +}
>> +
prev parent reply other threads:[~2020-02-11 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 13:20 [PATCH V2] mmc: sdhci-msm: Update system suspend/resume callbacks of sdhci-msm platform driver Shaik Sajida Bhanu
2020-02-10 19:41 ` Stephen Boyd
2020-02-11 14:38 ` sbhanu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328455c7256f41f3f3bd9b96fb21d8d@codeaurora.org \
--to=sbhanu@codeaurora.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=asutoshd@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cang@codeaurora.org \
--cc=devicetree-owner@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rampraka@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sayalil@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).