From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [v2, 4/4] dt-bindings: mtd: Add Octal SPI support to Cadence QSPI. Date: Fri, 10 Mar 2017 04:39:27 +0100 Message-ID: <132a4818-11d1-263f-aae4-bac4e76c14c8@gmail.com> References: <1488959932-6657-1-git-send-email-jartur@cadence.com> <1488960326-13858-1-git-send-email-jartur@cadence.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1488960326-13858-1-git-send-email-jartur-vna1KIf7WgpBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Artur Jedrysek , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Cyrille Pitchen , David Woodhouse , Brian Norris , Boris Brezillon , Richard Weinberger , Rob Herring , Mark Rutland List-Id: devicetree@vger.kernel.org On 03/08/2017 09:05 AM, Artur Jedrysek wrote: > This patch updates Cadence QSPI Device Tree documentation to include > information about new compatible used to indicate, whether or not > Octal SPI transfers are supported by the device. > > Signed-off-by: Artur Jedrysek > --- > Changelog: > v2: Use new compatible, instead of boolean property, to indicate > Octal SPI support. > --- > Documentation/devicetree/bindings/mtd/cadence-quadspi.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt b/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt > index f248056..41d1e98 100644 > --- a/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt > +++ b/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt > @@ -1,7 +1,9 @@ > * Cadence Quad SPI controller > > Required properties: > -- compatible : Should be "cdns,qspi-nor". > +- compatible : Should be "cdns,{qspi|ospi}-nor". Please explicitly list all compatibles , ie. Should be "cdns,qspi-nor" or "cdns,ospi-nor". But I think the ospi is backward compatible with qspi, right ? So the binding for ospi should list both, ie. compatible = "cdns,ospi-nor", "cdns,qspi-nor"; > + Use "cdns,qspi-nor" for Quad SPI controller. > + Use "cdns,ospi-nor" for Octal SPI controller. > - reg : Contains two entries, each of which is a tuple consisting of a > physical address and length. The first entry is the address and > length of the controller register set. The second entry is the > -- Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html