From: "Heiko Stübner" <heiko@sntech.de>
To: Doug Anderson <dianders@chromium.org>
Cc: Mark Brown <broonie@kernel.org>, Chris Zhong <zyw@rock-chips.com>,
Sonny Rao <sonnyrao@chromium.org>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, zhangqing@rock-chips.com,
lgirdwood@gmail.com, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, galak@codeaurora.org
Subject: Re: [PATCH 0/2] Add input supplies to rk808 regulator
Date: Tue, 02 Sep 2014 21:48:14 +0200 [thread overview]
Message-ID: <13302580.b33ghgBegF@diego> (raw)
In-Reply-To: <1409674469-12123-1-git-send-email-dianders@chromium.org>
Am Dienstag, 2. September 2014, 09:14:27 schrieb Doug Anderson:
> We want to specify the input supplies to the rk808 regulator. This
> patch series adds them to the driver. Note that the bindings are
> based atop Chris's most recent version at
> <https://patchwork.kernel.org/patch/4817931/>. If the regulator patch
> is applied before Chris sends out his next version then I think Chris
> could squash my bindings change (patch 2) into his next version.
>
>
> Doug Anderson (2):
> regulator: RK808: Add proper input supplies for rk808
Patch 1 didn't apply, as it didn't take the recent pdata removal Chris
posted. After fixing this [0], it sucessfully solved the missing supplies
I've seen on the weekend, so
Tested-by: Heiko Stuebner <heiko@sntech.de>
> dt-bindings: Add input supplies to rk808 bindings
>
> Documentation/devicetree/bindings/mfd/rk808.txt | 11 +++++++++++
> drivers/regulator/rk808-regulator.c | 15 ++++++++++++++-
> 2 files changed, 25 insertions(+), 1 deletion(-)
[0]
--- "[PATCH 1_2] regulator_RK808_Add proper input supplies for rk808.mbox.orig" 2014-09-02 20:49:12.000000000 +0200
+++ "[PATCH 1_2] regulator_RK808_Add proper input supplies for rk808.mbox" 2014-09-02 21:22:57.052197875 +0200
@@ -203,7 +203,7 @@
.type = REGULATOR_VOLTAGE,
@@ -364,7 +378,6 @@ static int rk808_regulator_probe(struct platform_device *pdev)
if (client->dev.of_node)
- config.of_node = pdata->of_node[i];
+ config.of_node = rk808_regulator->of_node[i];
- reg_data->supply_regulator = rk808_reg[i].name;
config.init_data = reg_data;
As Chris is supposed to merge these changes into his series, this doesn't
really matter though.
next prev parent reply other threads:[~2014-09-02 19:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 16:14 [PATCH 0/2] Add input supplies to rk808 regulator Doug Anderson
2014-09-02 16:14 ` [PATCH 2/2] dt-bindings: Add input supplies to rk808 bindings Doug Anderson
[not found] ` <1409674469-12123-3-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-09-02 16:31 ` Mark Brown
[not found] ` <20140902163105.GY29327-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-02 16:53 ` Doug Anderson
2014-09-02 19:48 ` Heiko Stübner [this message]
2014-09-02 19:50 ` [PATCH 0/2] Add input supplies to rk808 regulator Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13302580.b33ghgBegF@diego \
--to=heiko@sntech.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sonnyrao@chromium.org \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).