From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dong Aisheng Subject: [PATCH 1/1] of: add NULL parameter check for of_device_is_available Date: Tue, 13 Mar 2012 19:40:05 +0800 Message-ID: <1331638805-17136-1-git-send-email-b29396@freescale.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Sender: linux-kernel-owner@vger.kernel.org To: devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: grant.likely@secretlab.ca, rob.herring@calxeda.com List-Id: devicetree@vger.kernel.org From: Dong Aisheng This function will return 1 even the device node passed in is NULL which is a little error-prone. Change to return 0 if the device node passed in is NULL. Signed-off-by: Dong Aisheng --- drivers/of/base.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index 133908a..b9347d8 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -280,6 +280,9 @@ int of_device_is_available(const struct device_node *device) const char *status; int statlen; + if (device == NULL) + return 0; + status = of_get_property(device, "status", &statlen); if (status == NULL) return 1; -- 1.7.0.4