devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Lentin <jm@lentin.co.uk>
To: Arnd Bergmann <arnd@arndb.de>, Jason <jason@lakedaemon.net>,
	Grant Likely <grant.likely@secretlab.ca>,
	Andrew Lunn <andrew@lunn.ch>
Cc: devicetree-discuss@lists.ozlabs.org,
	Jamie Lentin <jm@lentin.co.uk>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5 0/4] ARM: Kirkwood: Add support for DNS-320 and DNS-325 using devicetree
Date: Wed, 18 Apr 2012 11:06:39 +0100	[thread overview]
Message-ID: <1334743603-8488-1-git-send-email-jm@lentin.co.uk> (raw)

Reworked patch for latest feedback. I'm still basing this on Jason Cooper's
tree, given how much time has passed should I be rebasing against something
else or is this still fine?

One thing I noticed is that with only the first patch applied (which no
longer calls kirkwood_nand_init) the device either locks up or serial console
dies at "Gating clock of unused units", presumably as CGC_RUNIT isn't set.
Is this something known or is it worth further investigation?

Thanks again to everyone reviewing.

Changes since v4: Convert DNS-325 & DNS-320 to access nand via devicetree
* Add initial support patch back in to address following comments
** One MACH_DLINK_KIRKWOOD_DT for all dtb files [Grant Likely, Jason Cooper]
** Drop brain-dead select "select CONFIG_MTD_OF_PARTS" [Grant Likely]
** Don't add NAND support then throw it away immediately after [Grant Likely]
* WARN when bank-width is out of range [Andrew Lunn]
* Describe purpose of MPP 41, 42 & 49

Changes since v3: Add support for DNS-320 and DNS-325 using devicetree
* Remove patches that are already merged
* Add documentation on orion_nand devicetree bindings
* Convert bank-width to be in bytes to match other properties
* Make defaults more explicit

Changes since v2: Add support for DNS-320 and DNS-325 using devicetree
* Split patches further, separating orion_nand and kirkwood changes
* dts renames: "bank-width", not "width". "okay", not "ok"
* Separate documentation out into separate patch, add references to
  partition.txt to all mtd bindings.

Changes since v1: Add support for DNS-320 and DNS-325 using devicetree
* Rebase against kirkwood_dt_for_3.4, removing premature devicetree ports.
* Move additions into a separate board-dnskw.c. It could be separated further
  into a board-dns320.c and board-dns325.c but it probably isn't worth it.
* s/marvell,/mrvl,/g
* Include an example dtb partition in documentation
* Copy structure of serial nodes to allow common options for NAND to be set
  in kirkwood.dtsi
* Simplifications in orion-nand.c

Jamie Lentin (4):
  ARM: kirkwood: Basic support for DNS-320 and DNS-325
  mtd: Add orion_nand devicetree bindings
  kirkwood: Allow nand to be configured via. devicetree
  ARM: kirkwood: Define DNS-320/DNS-325 NAND in fdt

 .../devicetree/bindings/mtd/orion-nand.txt         |   50 ++++
 arch/arm/boot/dts/kirkwood-dns320.dts              |   64 +++++
 arch/arm/boot/dts/kirkwood-dns325.dts              |   59 +++++
 arch/arm/boot/dts/kirkwood.dtsi                    |   15 +-
 arch/arm/mach-kirkwood/Kconfig                     |    8 +
 arch/arm/mach-kirkwood/Makefile                    |    1 +
 arch/arm/mach-kirkwood/Makefile.boot               |    2 +
 arch/arm/mach-kirkwood/board-dnskw.c               |  275 ++++++++++++++++++++
 arch/arm/mach-kirkwood/board-dt.c                  |    5 +
 arch/arm/mach-kirkwood/common.c                    |   12 +
 arch/arm/mach-kirkwood/common.h                    |    6 +
 drivers/mtd/nand/orion_nand.c                      |   45 +++-
 12 files changed, 539 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mtd/orion-nand.txt
 create mode 100644 arch/arm/boot/dts/kirkwood-dns320.dts
 create mode 100644 arch/arm/boot/dts/kirkwood-dns325.dts
 create mode 100644 arch/arm/mach-kirkwood/board-dnskw.c

-- 
1.7.9.1

             reply	other threads:[~2012-04-18 10:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-18 10:06 Jamie Lentin [this message]
2012-04-18 10:06 ` [PATCH V5 1/4] ARM: kirkwood: Basic support for DNS-320 and DNS-325 Jamie Lentin
2012-04-18 10:06 ` [PATCH V5 2/4] mtd: Add orion_nand devicetree bindings Jamie Lentin
     [not found] ` <1334743603-8488-1-git-send-email-jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
2012-04-18 10:06   ` [PATCH V5 3/4] kirkwood: Allow nand to be configured via. devicetree Jamie Lentin
2012-04-18 10:06   ` [PATCH V5 4/4] ARM: kirkwood: Define DNS-320/DNS-325 NAND in fdt Jamie Lentin
2012-04-18 13:16   ` [PATCH V5 0/4] ARM: Kirkwood: Add support for DNS-320 and DNS-325 using devicetree Jason Cooper
2012-04-18 13:24     ` Andrew Lunn
     [not found]       ` <20120418132445.GB25584-g2DYL2Zd6BY@public.gmane.org>
2012-04-18 14:04         ` Jason Cooper
     [not found]           ` <20120418140440.GL15711-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-04-18 15:44             ` Jamie Lentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334743603-8488-1-git-send-email-jm@lentin.co.uk \
    --to=jm@lentin.co.uk \
    --cc=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).